From: Vinod Koul <vinod.koul@intel.com>
To: Alexandrov Stansilav <neko@nya.ai>
Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH v2 1/2] ASoC: rt5640: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet.
Date: Thu, 5 Jan 2017 09:19:49 +0530 [thread overview]
Message-ID: <20170105034948.GJ3573@localhost> (raw)
In-Reply-To: <9e2493401df1f2f0419fa175b4fc9a84eb971e28.1483531270.git.neko@nya.ai>
On Wed, Jan 04, 2017 at 03:22:12PM +0300, Alexandrov Stansilav wrote:
This looks okay, but title is same for both of the patches. It would be
better to describe the change you are doing and not the outcome.
so a better title could be:
ASoC: rt5640: Add "10EC3276" ACPI ID
and in log say:
HP Pavilion x2 10-p000 comes with rt5640 with ACPI ID "10EC3276" so add
that.
> Signed-off-by: Alexandrov Stansilav <neko@nya.ai>
> ---
> sound/soc/codecs/rt5640.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
> index e29a6de..b857a71 100644
> --- a/sound/soc/codecs/rt5640.c
> +++ b/sound/soc/codecs/rt5640.c
> @@ -2313,6 +2313,7 @@ MODULE_DEVICE_TABLE(of, rt5640_of_match);
> #ifdef CONFIG_ACPI
> static const struct acpi_device_id rt5640_acpi_match[] = {
> { "INT33CA", 0 },
> + { "10EC3276", 0 },
> { "10EC5640", 0 },
> { "10EC5642", 0 },
> { "INTCCFFD", 0 },
> --
> 2.10.2
>
--
~Vinod
next prev parent reply other threads:[~2017-01-05 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 12:22 [PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Alexandrov Stansilav
2017-01-04 12:22 ` [PATCH v2 1/2] ASoC: rt5640: " Alexandrov Stansilav
2017-01-05 3:49 ` Vinod Koul [this message]
2017-01-06 0:27 ` Alexandrov Stanislav
2017-01-31 21:18 ` Applied "ASoC: rt5640: Add "10EC3276" ACPI ID" to the asoc tree Mark Brown
2017-01-04 12:22 ` [PATCH v2 2/2] ASoC: Intel: Atom: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Alexandrov Stansilav
2017-01-05 3:52 ` Vinod Koul
2017-01-31 21:18 ` Applied "ASoC: Intel: Atom: Add HP Pavilion x2 10-p000 machine entry" to the asoc tree Mark Brown
2017-01-04 16:41 ` [PATCH v2 0/2] ASoC: Add support for rt5640 sound card found on HP Pavilion x2 10-p000 tablet Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105034948.GJ3573@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=neko@nya.ai \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).