From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v3 4/4] ASoC: Intel: rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM Date: Thu, 5 Jan 2017 09:23:47 +0530 Message-ID: <20170105035347.GL3573@localhost> References: <20170102152017.13938-1-andriy.shevchenko@linux.intel.com> <20170102152017.13938-5-andriy.shevchenko@linux.intel.com> <20170103033815.GA3573@localhost> <1483526660.9552.221.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by alsa0.perex.cz (Postfix) with ESMTP id BD291266DB0 for ; Thu, 5 Jan 2017 04:53:53 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: dmaengine , alsa-devel@alsa-project.org, Andy Shevchenko , Jie Yang , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Jan 04, 2017 at 10:58:50AM -0600, Pierre-Louis Bossart wrote: > On 1/4/17 4:44 AM, Andy Shevchenko wrote: > >On Tue, 2017-01-03 at 08:18 -0600, Pierre-Louis Bossart wrote: > >>>>On 01/02/2017 09:20 AM, Andy Shevchenko wrote: > >>>>>Rename SND_SST_MFLD_PLATFORM to SND_SST_MID_PLATFORM to make it > >>>>>clear that is > >>>>>not only about Medfield platform. > >>>> > >>>>Does this change make sense? Medfield was a completely different > >>>>platform and lumping everything under the same Kconfig option > >>>>doesn't seem right to me... Plus we've stopped using 'mid' for > >>>>years, no one would know what it stands for. The only clear > >>>>architecture feature is the presence of the switch matrix that > >>>>uniquely identifies all platforms based on Baytrail, Cherrytrail, > >>>>Merrifield and Anniedale. Medfield/Clovertrail did not expose a > >>>>switch matrix. > >>> > >>>Mea culpa.. > >>> > >>>So we started this with medfield and the driver construction is > >>>pretty much > >>>the same untill skylake. So clubbing under mfld bucket made sense to > >>>me. > >>> > >>>MID is not flavour of the season now. > > > >Would be, though it covers at least few out of them, MFLD just refers to > >one. > > > >>> > >>>If anyone comes with a better name, am for that :) > > > >_ATOM ? Sounds too broad... > > > >> > >>SND_SST_HIFI2_MOBILE_PLATFORM ? > > > >Where HIFI2 part came from? Any documentation (maybe internal) available > >to look at? (Because it's not obvious to me how all listed above has > >something in common) > > > >And I would get rid of _MOBILE part. > > SND_SST_ATOM_HIFI2_PLATFORM then sounds okay to me.. > > HIFI2 is the DSP version, it's public information for those > Field/Trail parts, see > https://www.alsa-project.org/main/index.php/Firmware > If you combine HIFI2 with ATOM you have a unique non-ambiguous > description of the core+DSP hardware for Medfield through > Cherrytrail. > > -- ~Vinod