From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Darren Hart" <dvhart@infradead.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Anthony Wong" <anthony.wong@canonical.com>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c
Date: Tue, 17 Jan 2017 12:28:17 +0100 [thread overview]
Message-ID: <20170117112817.GD32502@pali> (raw)
In-Reply-To: <20170117110809.GC26116@xo-6d-61-c0.localdomain>
On Tuesday 17 January 2017 12:08:09 Pavel Machek wrote:
> Hi!
>
> > Thanks for the patch set.
> >
> > Would you mind fixing also the following issues raised by
> > checkpatch.pl?:
> >
> > WARNING: Missing a blank line after declarations
> > #376: FILE: drivers/platform/x86/dell-wmi-led.c:64:
> > + struct bios_args args;
> ...
> > The fixes could be placed in an incremental patch after this one.
>
> Anyway, move itself is ok (and the checkpatch issues are not that serious anyway.)
>
> Thanks,
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Yes, this patch does not change code, just move one file to other
location. You can add my Reviewed-by.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2017-01-17 11:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:21 [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Michał Kępień
2017-01-16 13:21 ` [PATCH v2 1/6] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2017-01-16 13:22 ` [PATCH v2 2/6] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2017-01-16 13:22 ` [PATCH v2 3/6] ALSA: hda - rename dell_led_set_func to dell_micmute_led_set_func Michał Kępień
2017-01-17 11:12 ` Pali Rohár
2017-01-17 21:20 ` Jacek Anaszewski
2017-01-16 13:22 ` [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2017-01-17 11:23 ` Pali Rohár
2017-01-18 19:12 ` Andy Shevchenko
2017-01-16 13:22 ` [PATCH v2 5/6] dell-led: remove code related to mic mute LED Michał Kępień
2017-01-17 11:24 ` Pali Rohár
2017-01-16 13:22 ` [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2017-01-16 20:49 ` Jacek Anaszewski
2017-01-17 11:08 ` Pavel Machek
2017-01-17 11:28 ` Pali Rohár [this message]
2017-01-18 19:08 ` Andy Shevchenko
2017-01-17 7:17 ` [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues Michał Kępień
2017-01-17 8:21 ` Joe Perches
2017-01-17 9:19 ` Michał Kępień
2017-01-17 21:20 ` Jacek Anaszewski
2017-01-17 11:08 ` Pavel Machek
2017-01-18 19:06 ` Andy Shevchenko
2017-01-17 21:20 ` [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Jacek Anaszewski
2017-02-13 11:26 ` Michał Kępień
2017-02-15 11:56 ` Alex Hung
2017-02-15 13:54 ` Michał Kępień
2017-02-15 14:31 ` Alex Hung
2017-02-15 15:12 ` Pali Rohár
2017-02-16 9:33 ` Michał Kępień
2017-02-16 9:27 ` Michał Kępień
2017-02-16 10:35 ` Alex Hung
2017-02-16 11:32 ` Michał Kępień
2017-02-16 11:38 ` Alex Hung
2017-02-16 11:41 ` Andy Shevchenko
2017-02-16 12:01 ` Michał Kępień
2017-02-16 13:11 ` Andy Shevchenko
2017-02-16 22:11 ` Jacek Anaszewski
2017-02-15 20:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117112817.GD32502@pali \
--to=pali.rohar@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=anthony.wong@canonical.com \
--cc=dvhart@infradead.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).