From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Sakamoto <takashi.sakamoto@miraclelinux.com>
Cc: alsa-devel@alsa-project.org, hirotaka.furukawa@miraclelinux.com,
ichiro.suzuki@miraclelinux.com, ryotaro.shibata@miraclelinux.com,
"# v4 . 5+" <stable@vger.kernel.org>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
broonie@kernel.org, shreyas.nc@intel.com, jeeja.kp@intel.com,
yukie.kato@miraclelinux.com
Subject: Re: [PATCH] ASoC: Intel: Skylake: fix invalid memory access due to wrong reference of pointer
Date: Thu, 2 Mar 2017 14:26:13 +0530 [thread overview]
Message-ID: <20170302085612.GR2843@localhost> (raw)
In-Reply-To: <20170224024841.10515-1-takashi.sakamoto@miraclelinux.com>
On Fri, Feb 24, 2017 at 11:48:41AM +0900, Takashi Sakamoto wrote:
> In 'skl_tplg_set_module_init_data()', a pointer to 'params' member of
> 'struct skl_algo_data' is calculated, then casted to (u32 *) and assigned
> to a member of configuration data. The configuration data is passed to the
> other functions and used to process intel IPC. In this processing, the
> value of member is used to get message data, however this can bring invalid
> memory access in 'skl_set_module_params()' as a result of calculation of
> a pointer for actual message data.
>
> (sound/soc/intel/skylake/skl-topology.c)
> skl_tplg_init_pipe_modules()
> ->skl_tplg_set_module_init_data() (has this bug)
> ->skl_tplg_set_module_params()
> (sound/soc/intel/skylake/skl-messages.c)
> ->skl_set_module_params()
> ((char *)param) + data_offset
>
> This commit fixes the bug.
Thanks Takashi San for the fix
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2017-03-02 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 2:48 [PATCH] ASoC: Intel: Skylake: fix invalid memory access due to wrong reference of pointer Takashi Sakamoto
2017-03-02 8:56 ` Vinod Koul [this message]
2017-03-07 14:21 ` Applied "ASoC: Intel: Skylake: fix invalid memory access due to wrong reference of pointer" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170302085612.GR2843@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hirotaka.furukawa@miraclelinux.com \
--cc=ichiro.suzuki@miraclelinux.com \
--cc=jeeja.kp@intel.com \
--cc=o-takashi@sakamocchi.jp \
--cc=ryotaro.shibata@miraclelinux.com \
--cc=shreyas.nc@intel.com \
--cc=stable@vger.kernel.org \
--cc=takashi.sakamoto@miraclelinux.com \
--cc=yukie.kato@miraclelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).