* [PATCH] ALSA: hda/ca0132: Remove double parentheses
@ 2017-03-15 22:41 Matthias Kaehlcke
2017-03-20 11:55 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2017-03-15 22:41 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Julia Lawall, Sven Hahne
Cc: alsa-devel, linux-kernel, Grant Grundler, Matthias Kaehlcke
The extra pairs of parantheses are not needed and causes clang to
generate warnings like this:
sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ((buffer == NULL))
~~~~~~~^~~~~~~
sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning
if ((buffer == NULL))
~ ^ ~
sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment
if ((buffer == NULL))
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
sound/pci/hda/patch_ca0132.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 11b9b2f17a2e..9cc1bbbbef32 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -1168,7 +1168,7 @@ static int dspio_write_multiple(struct hda_codec *codec,
int status = 0;
unsigned int count;
- if ((buffer == NULL))
+ if (buffer == NULL)
return -EINVAL;
count = 0;
@@ -1210,7 +1210,7 @@ static int dspio_read_multiple(struct hda_codec *codec, unsigned int *buffer,
unsigned int skip_count;
unsigned int dummy;
- if ((buffer == NULL))
+ if (buffer == NULL)
return -1;
count = 0;
--
2.12.0.367.g23dc2f6d3c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses
2017-03-15 22:41 [PATCH] ALSA: hda/ca0132: Remove double parentheses Matthias Kaehlcke
@ 2017-03-20 11:55 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-03-20 11:55 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: alsa-devel, Grant Grundler, linux-kernel, Julia Lawall,
Sven Hahne
On Wed, 15 Mar 2017 23:41:23 +0100,
Matthias Kaehlcke wrote:
>
> The extra pairs of parantheses are not needed and causes clang to
> generate warnings like this:
>
> sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
> if ((buffer == NULL))
> ~~~~~~~^~~~~~~
> sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning
> if ((buffer == NULL))
> ~ ^ ~
> sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment
> if ((buffer == NULL))
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-20 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 22:41 [PATCH] ALSA: hda/ca0132: Remove double parentheses Matthias Kaehlcke
2017-03-20 11:55 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).