* [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit
@ 2017-03-16 20:52 Matthias Kaehlcke
2017-03-20 9:33 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-03-16 20:52 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Sven Hahne, Julia Lawall
Cc: alsa-devel, linux-kernel, Grant Grundler, Michael Davidson,
Greg Hackmann, Matthias Kaehlcke
With the previous unsigned long value clang generates warnings like
this:
sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
'unsigned long' to 'u32' (aka 'unsigned int') changes value from
18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
~ ^~~~
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
sound/pci/hda/patch_ca0132.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 11b9b2f17a2e..7175e2b46fc4 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
chip_addx >> 16);
}
- spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
+ spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;
return res;
}
@@ -882,7 +882,7 @@ static int chipio_write_data(struct hda_codec *codec, unsigned int data)
/*If no error encountered, automatically increment the address
as per chip behaviour*/
spec->curr_chip_addx = (res != -EIO) ?
- (spec->curr_chip_addx + 4) : ~0UL;
+ (spec->curr_chip_addx + 4) : (u32)~0U;
return res;
}
@@ -933,7 +933,7 @@ static int chipio_read_data(struct hda_codec *codec, unsigned int *data)
/*If no error encountered, automatically increment the address
as per chip behaviour*/
spec->curr_chip_addx = (res != -EIO) ?
- (spec->curr_chip_addx + 4) : ~0UL;
+ (spec->curr_chip_addx + 4) : (u32)~0U;
return res;
}
--
2.12.0.367.g23dc2f6d3c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit
2017-03-16 20:52 [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit Matthias Kaehlcke
@ 2017-03-20 9:33 ` Takashi Iwai
2017-04-01 0:52 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2017-03-20 9:33 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: alsa-devel, Grant Grundler, linux-kernel, Greg Hackmann,
Michael Davidson, Julia Lawall, Sven Hahne
On Thu, 16 Mar 2017 21:52:23 +0100,
Matthias Kaehlcke wrote:
>
> With the previous unsigned long value clang generates warnings like
> this:
>
> sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
> 'unsigned long' to 'u32' (aka 'unsigned int') changes value from
> 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
> spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> ~ ^~~~
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Thanks for the patch. The changes look mostly OK, but...
> ---
> sound/pci/hda/patch_ca0132.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 11b9b2f17a2e..7175e2b46fc4 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
> chip_addx >> 16);
> }
>
> - spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> + spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;
... I guess the cast to u32 is superfluous here? That is, just
replace UL to U should work, I suppose. (Ditto for all other places.)
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit
2017-03-20 9:33 ` Takashi Iwai
@ 2017-04-01 0:52 ` Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-04-01 0:52 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, Grant Grundler, linux-kernel, Greg Hackmann,
Michael Davidson, Julia Lawall, Sven Hahne
Sorry for the delayed reply,
El Mon, Mar 20, 2017 at 10:33:43AM +0100 Takashi Iwai ha dit:
> On Thu, 16 Mar 2017 21:52:23 +0100,
> Matthias Kaehlcke wrote:
> >
> > With the previous unsigned long value clang generates warnings like
> > this:
> >
> > sound/pci/hda/patch_ca0132.c:860:37: error: implicit conversion from
> > 'unsigned long' to 'u32' (aka 'unsigned int') changes value from
> > 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
> > spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> > ~ ^~~~
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> Thanks for the patch. The changes look mostly OK, but...
>
> > ---
> > sound/pci/hda/patch_ca0132.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> > index 11b9b2f17a2e..7175e2b46fc4 100644
> > --- a/sound/pci/hda/patch_ca0132.c
> > +++ b/sound/pci/hda/patch_ca0132.c
> > @@ -857,7 +857,7 @@ static int chipio_write_address(struct hda_codec *codec,
> > chip_addx >> 16);
> > }
> >
> > - spec->curr_chip_addx = (res < 0) ? ~0UL : chip_addx;
> > + spec->curr_chip_addx = (res < 0) ? (u32)~0U : chip_addx;
>
> ... I guess the cast to u32 is superfluous here? That is, just
> replace UL to U should work, I suppose. (Ditto for all other places.)
You are right, the cast is not needed. I'll send an updated version.
Cheers
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-01 0:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-16 20:52 [PATCH] ALSA: hda/ca0132: Limit values for chip addresses to 32-bit Matthias Kaehlcke
2017-03-20 9:33 ` Takashi Iwai
2017-04-01 0:52 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).