From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Brown <broonie@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-renesas-soc@vger.kernel.org,
Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@renesas.com>
Subject: Re: [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT
Date: Fri, 24 Mar 2017 07:55:12 +0100 [thread overview]
Message-ID: <20170324065512.GH1319@verge.net.au> (raw)
In-Reply-To: <87o9wtofqy.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Mar 22, 2017 at 08:56:07AM +0000, Kuninori Morimoto wrote:
>
> Hi Sergei
>
> > > /*
> > > + * It will set SSIWSR.CONT here, but SSICR.CKDV = 000
> > > + * with it is not allowed. (SSIWSR.WS_MODE with
> > > + * SSICR.CKDV = 000 is not allowed either).
> > > + * Skip it. See SSICR.CKDV
> > > + */
> > > + if (j == 0)
> > > + continue;
> >
> > Why not change the *for* statement itself to start with j = 1?
>
> It can be one solution. Actually my local 1st patch was such style.
> But I thought that it is difficult to notice such magical operation from code.
> Thus, I used this style
FWIIW, I think if you have a comment, like the one above, then j = 1 should
be obvious enough.
next prev parent reply other threads:[~2017-03-24 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 4:02 [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT Kuninori Morimoto
2017-03-22 8:48 ` Sergei Shtylyov
2017-03-22 8:56 ` Kuninori Morimoto
2017-03-24 6:55 ` Simon Horman [this message]
2017-03-24 8:32 ` Kuninori Morimoto
2017-03-24 19:16 ` Applied "ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324065512.GH1319@verge.net.au \
--to=horms@verge.net.au \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hiroyuki.yokoyama.vx@renesas.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).