From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH] ASoC: intel: Don't print FW version repeatedly
Date: Mon, 27 Mar 2017 15:55:25 +0530 [thread overview]
Message-ID: <20170327102525.GJ9308@localhost> (raw)
In-Reply-To: <20170327101354.fgvu2s6ewdccha67@sirena.org.uk>
On Mon, Mar 27, 2017 at 11:13:54AM +0100, Mark Brown wrote:
> On Mon, Mar 27, 2017 at 03:36:58PM +0530, Vinod Koul wrote:
> > On Mon, Mar 27, 2017 at 10:39:58AM +0200, Takashi Iwai wrote:
>
> > > - dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
> > > + if (memcmp(&sst_drv_ctx->fw_version, &init->fw_version,
> > > + sizeof(init->fw_version)))
>
> > wont dev_info_once be better here? We are really not expecting a new version
> > after suspend :)
>
> You are if someone upgrades their userspace.
Ah yes thats a good point indeed, so:
Acked-by: Vinod Koul <vinod.koul@intel.com>
Thanks
--
~Vinod
next prev parent reply other threads:[~2017-03-27 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 8:39 [PATCH] ASoC: intel: Don't print FW version repeatedly Takashi Iwai
2017-03-27 10:06 ` Vinod Koul
2017-03-27 10:13 ` Mark Brown
2017-03-27 10:24 ` Takashi Iwai
2017-03-27 10:37 ` Vinod Koul
2017-03-27 12:10 ` Takashi Iwai
2017-03-27 10:25 ` Vinod Koul [this message]
2017-03-27 11:32 ` Applied "ASoC: intel: Don't print FW version repeatedly" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327102525.GJ9308@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).