Re: [PATCH] ASoC: intel: Don't print FW version repeatedly

[Vinod Koul <vinod.koul@intel.com>]

On Mon, Mar 27, 2017 at 12:24:20PM +0200, Takashi Iwai wrote:
> On Mon, 27 Mar 2017 12:13:54 +0200,
> Mark Brown wrote:
> > 
> > On Mon, Mar 27, 2017 at 03:36:58PM +0530, Vinod Koul wrote:
> > > On Mon, Mar 27, 2017 at 10:39:58AM +0200, Takashi Iwai wrote:
> > 
> > > > -	dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
> > > > +	if (memcmp(&sst_drv_ctx->fw_version, &init->fw_version,
> > > > +		   sizeof(init->fw_version)))
> > 
> > > wont dev_info_once be better here? We are really not expecting a new version
> > > after suspend :)
> > 
> > You are if someone upgrades their userspace.
> 
> Right.  If we want to keep the old one consistently, you should cache
> the firmware instead of doing request_firmware at each time.

Ah great thanks for reminding, we actually do that, so we don't load from
userspace all the time. That was done to get good latency and avoid 50ms ish
time it used to load the firmware.

see sst_cache_and_parse_fw() so dev_info_once() would suffice here

-- 
~Vinod