From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: PM issue with Intel SST Atom driver
Date: Tue, 25 Apr 2017 08:34:15 +0530 [thread overview]
Message-ID: <20170425030415.GV6263@localhost> (raw)
In-Reply-To: <s5h8tmpk66p.wl-tiwai@suse.de>
On Mon, Apr 24, 2017 at 08:32:14PM +0200, Takashi Iwai wrote:
> On Mon, 24 Apr 2017 18:27:38 +0200,
> >
> > So we should add the remaining one byt-max98090.c as Takashi fixed
> > byt-rt5640.c one. I will send the patch for this one.
>
> Or maybe we should replace these definitions with some macro to expand
> to the mostly same contents? The difference is just a few callback
> functions, basically.
And while at it, I cant help but wonder but if we can do better and mark it
in platform driver thus avoiding it replication in machines. Afterall the
atomic trigger is a platform property.
Thanks
--
~Vinod
next prev parent reply other threads:[~2017-04-25 3:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 13:42 PM issue with Intel SST Atom driver Takashi Iwai
2017-04-24 5:01 ` Vinod Koul
2017-04-24 7:15 ` Takashi Iwai
2017-04-24 9:00 ` Takashi Iwai
2017-04-24 9:12 ` Vinod Koul
2017-04-24 9:43 ` Takashi Iwai
2017-04-24 9:52 ` Vinod Koul
2017-04-24 9:54 ` Takashi Iwai
2017-04-24 11:02 ` Vinod Koul
2017-04-24 14:22 ` Pierre-Louis Bossart
2017-04-24 16:27 ` Vinod Koul
2017-04-24 18:32 ` Takashi Iwai
2017-04-25 3:04 ` Vinod Koul [this message]
2017-04-24 19:01 ` Pierre-Louis Bossart
2017-04-25 3:06 ` Vinod Koul
2017-04-24 9:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425030415.GV6263@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox