From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jeeja KP <jeeja.kp@intel.com>,
Jayachandran B <jayachandran.b@intel.com>,
Senthilnathan Veppur <senthilnathanx.veppur@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
Ramesh Babu <ramesh.babu@intel.com>,
G Kranthi <gudishax.kranthikumar@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use
Date: Thu, 27 Apr 2017 19:58:10 +0530 [thread overview]
Message-ID: <20170427142810.GJ6263@localhost> (raw)
In-Reply-To: <20170427110014.2316664-1-arnd@arndb.de>
On Thu, Apr 27, 2017 at 12:59:58PM +0200, Arnd Bergmann wrote:
> The error handling in bxt_sst_dsp_init() got changed in a way that
> it now derefences an uninitialized pointer when printing a warning
> about the device not being found:
>
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> As we do have a valid device pointer available at the call site,
> let's use that instead.
Thanks Arnd for this fix, but this was also reported by SFR earlier today
and have pasoted same patch via
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120214.html
Patches are same, so Mark can take either :)
--
~Vinod
prev parent reply other threads:[~2017-04-27 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 10:59 [PATCH] ASoC: Intel: Skylake: fix uninitialized pointer use Arnd Bergmann
2017-04-27 11:13 ` Takashi Sakamoto
2017-04-27 14:28 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427142810.GJ6263@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=gudishax.kranthikumar@intel.com \
--cc=jayachandran.b@intel.com \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ramesh.babu@intel.com \
--cc=senthilnathanx.veppur@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).