From: Johan Hovold <johan@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH 0/3] ALSA: USB-descriptor endianess fixes
Date: Fri, 12 May 2017 14:16:33 +0200 [thread overview]
Message-ID: <20170512121633.GR30445@localhost> (raw)
In-Reply-To: <s5h37cafhmv.wl-tiwai@suse.de>
On Fri, May 12, 2017 at 01:18:16PM +0200, Takashi Iwai wrote:
> On Fri, 12 May 2017 12:28:18 +0200,
> Johan Hovold wrote:
> >
> > These patches add missing endianness conversions when accessing the USB
> > device-descriptor fields. In the process, clean up the us122l driver
> > which had product-id conditionals sprinkled throughout.
> >
> > The final patch drops the Kconfig dependency on x86 since it's a USB
> > driver that compiles just fine on non-x86. Perhaps this should be a
> > (X86 || COMPILE_TEST) dependency instead in case there are external
> > dependencies that warrants this limitation.
>
> Yeah, I vaguely remember that the driver is specific to x86 because of
> its particular usage of mmap. Maybe some other architectures may
> match, but not all. So, X86 || COMPILE_TEST would be more sensible.
Thanks for clarifying. I'll respin in a v2.
Johan
prev parent reply other threads:[~2017-05-12 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 10:28 [PATCH 0/3] ALSA: USB-descriptor endianess fixes Johan Hovold
2017-05-12 10:28 ` [PATCH 1/3] ALSA: usb-audio: fix Amanero Combo384 quirk on big-endian hosts Johan Hovold
2017-05-12 10:28 ` [PATCH 2/3] ALSA: us122l: clean up US144 handling Johan Hovold
2017-05-12 10:28 ` [PATCH 3/3] ALSA: us122l: drop x86 dependency Johan Hovold
2017-05-12 11:18 ` [PATCH 0/3] ALSA: USB-descriptor endianess fixes Takashi Iwai
2017-05-12 12:16 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512121633.GR30445@localhost \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).