From: Vinod Koul <vinod.koul@intel.com>
To: Harsha Priya <harshapriya.n@intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH v2 2/3] ASoC: Intel: Convert all sst_codecs data defintion to c99 style
Date: Fri, 9 Jun 2017 09:28:52 +0530 [thread overview]
Message-ID: <20170609035852.GU2885@localhost> (raw)
In-Reply-To: <1496885261-10771-3-git-send-email-harshapriya.n@intel.com>
On Wed, Jun 07, 2017 at 06:27:40PM -0700, Harsha Priya wrote:
> C99 style struct initialization helps in readability as well as
> initialization of variables not specified as NULL. This patch
> changes the struct data defintions in skl.c that were not in c99 style.
here as well :(
> ---
> sound/soc/intel/skylake/skl.c | 23 +++++++++++++++++++----
> 1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
> index 4ebae85..6a79fc7 100644
> --- a/sound/soc/intel/skylake/skl.c
> +++ b/sound/soc/intel/skylake/skl.c
> @@ -876,10 +876,25 @@ static void skl_remove(struct pci_dev *pci)
> dev_set_drvdata(&pci->dev, NULL);
> }
>
> -static struct sst_codecs skl_codecs = { 1, {"NAU88L25"} };
> -static struct sst_codecs kbl_codecs = { 1, {"NAU88L25"} };
> -static struct sst_codecs bxt_codecs = { 1, {"MX98357A"} };
> -static struct sst_codecs kbl_poppy_codecs = { 1, {"10EC5663"} };
> +static struct sst_codecs skl_codecs = {
> + .num_codecs = 1,
> + .codecs = {"NAU88L25"}
> +};
> +
> +static struct sst_codecs kbl_codecs = {
> + .num_codecs = 1,
> + .codecs = {"NAU88L25"}
> +};
> +
> +static struct sst_codecs bxt_codecs = {
> + .num_codecs = 1,
> + .codecs = {"MX98357A"}
> +};
> +
> +static struct sst_codecs kbl_poppy_codecs = {
> + .num_codecs = 1,
> + .codecs = {"10EC5663"}
> +};
>
> static struct sst_acpi_mach sst_skl_devdata[] = {
> {
> --
> 1.9.1
>
--
~Vinod
next prev parent reply other threads:[~2017-06-09 3:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 1:27 [PATCH v2 0/3] ASoC: Intel: Add Kabylake machine driver for RT5663+RT5514+MAX98927 Harsha Priya
2017-06-08 1:27 ` [PATCH v2 1/3] ASoC: Intel: Add Kabylake machine driver for RT5514, RT5663 and MAX98927 Harsha Priya
2017-06-08 1:27 ` [PATCH v2 2/3] ASoC: Intel: Convert all sst_codecs data defintion to c99 style Harsha Priya
2017-06-09 3:58 ` Vinod Koul [this message]
2017-06-09 22:20 ` N, Harshapriya
2017-06-14 18:21 ` Applied "ASoC: Intel: Convert all sst_codecs data definition to c99 style" to the asoc tree Mark Brown
2017-06-08 1:27 ` [PATCH v2 3/3] ASoC: Intel: Add Kabylake RT5663+RT5514+MAX98927 machine driver entry Harsha Priya
2017-06-09 3:45 ` Vinod Koul
2017-06-09 22:19 ` N, Harshapriya
2017-06-12 5:17 ` Vinod Koul
2017-06-14 18:21 ` Applied "ASoC: Intel: Add Kabylake RT5663+RT5514+MAX98927 machine driver entry" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609035852.GU2885@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=harshapriya.n@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).