Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Subject: [PATCH 1/5] ALSA: Make CONFIG_SND_OSSEMUL user-selectable
Date: Fri,  9 Jun 2017 17:12:48 +0200	[thread overview]
Message-ID: <20170609151252.704-2-tiwai@suse.de> (raw)
In-Reply-To: <20170609151252.704-1-tiwai@suse.de>

Currently CONFIG_SND_OSSEMUL is selected by each config like
CONFIG_SND_PCM_OSS.  But, as see in the raw MIDI code that is built
conditionally with CONFIG_SND_OSSEMUL, we should rather make
CONFIG_SND_OSSEMUL user-selectable as the top kconfig item, and leave
the rest depending on it.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/Kconfig | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 9749f9e8b45c..3a9afc520d4e 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -59,12 +59,14 @@ config SND_SEQ_DUMMY
 	  will be called snd-seq-dummy.
 
 config SND_OSSEMUL
+	bool "Enable OSS Emulation"
 	select SOUND_OSS_CORE
-	bool
+	help
+	  This option enables the build of OSS emulation layer.
 
 config SND_MIXER_OSS
 	tristate "OSS Mixer API"
-	select SND_OSSEMUL
+	depends on SND_OSSEMUL
 	help
 	  To enable OSS mixer API emulation (/dev/mixer*), say Y here
 	  and read <file:Documentation/sound/alsa/OSS-Emulation.txt>.
@@ -76,7 +78,7 @@ config SND_MIXER_OSS
 
 config SND_PCM_OSS
 	tristate "OSS PCM (digital audio) API"
-	select SND_OSSEMUL
+	depends on SND_OSSEMUL
 	select SND_PCM
 	help
 	  To enable OSS digital audio (PCM) emulation (/dev/dsp*), say Y
@@ -110,7 +112,7 @@ config SND_PCM_TIMER
 config SND_SEQUENCER_OSS
 	bool "OSS Sequencer API"
 	depends on SND_SEQUENCER
-	select SND_OSSEMUL
+	depends on SND_OSSEMUL
 	help
 	  Say Y here to enable OSS sequencer emulation (both
 	  /dev/sequencer and /dev/music interfaces).
-- 
2.13.1

  reply	other threads:[~2017-06-09 15:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 15:12 [PATCH 0/5] ALSA: Reorganize kconfig for sequencer stuff Takashi Iwai
2017-06-09 15:12 ` Takashi Iwai [this message]
2017-06-09 15:12 ` [PATCH 2/5] ALSA: seq: Allow the tristate build of OSS emulation Takashi Iwai
2017-06-09 20:13   ` Takashi Iwai
2017-06-09 15:12 ` [PATCH 3/5] ALSA: seq: Reorganize kconfig and build Takashi Iwai
2017-06-09 15:12 ` [PATCH 4/5] ALSA: synth: Select snd-emux-synth explicitly Takashi Iwai
2017-06-09 15:12 ` [PATCH 5/5] ALSA: seq: Allow the modular sequencer registration Takashi Iwai
2017-06-10 19:44   ` Takashi Iwai
2017-06-12  6:54     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609151252.704-2-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox