From: Johan Hovold <johan@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>, Johan Hovold <johan@kernel.org>
Subject: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"
Date: Wed, 12 Jul 2017 17:55:30 +0200 [thread overview]
Message-ID: <20170712155530.17765-2-johan@kernel.org> (raw)
In-Reply-To: <20170712155530.17765-1-johan@kernel.org>
This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI
assignments"), which seems to have been based on a misunderstanding and
prevents the platform driver callbacks from being made (e.g. to
preallocate DMA memory).
The real culprit for the warnings about attempts to create duplicate
procfs entries was commit 99b04f4c4051 ("ASoC: add Component level
pcm_new/pcm_free" that broke PCM creation on systems that use more than
one platform component.
Fixes: f1013cdeeeb9 ("ASoC: ux500: drop platform DAI assignments")
Cc: stable <stable@vger.kernel.org> # 4.11
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
sound/soc/ux500/mop500.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/ux500/mop500.c b/sound/soc/ux500/mop500.c
index b50f68a439ce..ba9fc099cf67 100644
--- a/sound/soc/ux500/mop500.c
+++ b/sound/soc/ux500/mop500.c
@@ -33,6 +33,7 @@ static struct snd_soc_dai_link mop500_dai_links[] = {
.stream_name = "ab8500_0",
.cpu_dai_name = "ux500-msp-i2s.1",
.codec_dai_name = "ab8500-codec-dai.0",
+ .platform_name = "ux500-msp-i2s.1",
.codec_name = "ab8500-codec.0",
.init = mop500_ab8500_machine_init,
.ops = mop500_ab8500_ops,
@@ -42,6 +43,7 @@ static struct snd_soc_dai_link mop500_dai_links[] = {
.stream_name = "ab8500_1",
.cpu_dai_name = "ux500-msp-i2s.3",
.codec_dai_name = "ab8500-codec-dai.1",
+ .platform_name = "ux500-msp-i2s.3",
.codec_name = "ab8500-codec.0",
.init = NULL,
.ops = mop500_ab8500_ops,
@@ -85,6 +87,8 @@ static int mop500_of_probe(struct platform_device *pdev,
for (i = 0; i < 2; i++) {
mop500_dai_links[i].cpu_of_node = msp_np[i];
mop500_dai_links[i].cpu_dai_name = NULL;
+ mop500_dai_links[i].platform_of_node = msp_np[i];
+ mop500_dai_links[i].platform_name = NULL;
mop500_dai_links[i].codec_of_node = codec_np;
mop500_dai_links[i].codec_name = NULL;
}
--
2.13.2
next prev parent reply other threads:[~2017-07-12 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 15:55 [PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold
2017-07-12 15:55 ` Johan Hovold [this message]
2017-07-14 13:36 ` [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Linus Walleij
2017-07-17 8:07 ` Johan Hovold
2017-07-17 14:51 ` Mark Brown
2017-07-18 8:21 ` Johan Hovold
2017-07-18 10:06 ` Mark Brown
2017-07-18 10:36 ` Johan Hovold
2017-07-18 12:59 ` Mark Brown
2017-07-17 16:05 ` Applied "ASoC: ux500: Restore platform DAI assignments" to the asoc tree Mark Brown
2017-07-14 13:35 ` [PATCH 1/2] ASoC: fix pcm-creation regression Linus Walleij
2017-07-17 8:03 ` Johan Hovold
2017-07-17 16:05 ` Applied "ASoC: fix pcm-creation regression" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712155530.17765-2-johan@kernel.org \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).