From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Date: Mon, 17 Jul 2017 10:07:37 +0200 Message-ID: <20170717080737.GA29638@localhost> References: <20170712155530.17765-1-johan@kernel.org> <20170712155530.17765-2-johan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by alsa0.perex.cz (Postfix) with ESMTP id 6B70E266E0B for ; Mon, 17 Jul 2017 10:07:29 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id t72so12587936lff.0 for ; Mon, 17 Jul 2017 01:07:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Walleij Cc: "alsa-devel@alsa-project.org" , Kuninori Morimoto , Liam Girdwood , "linux-kernel@vger.kernel.org" , Takashi Iwai , stable , Mark Brown , Johan Hovold List-Id: alsa-devel@alsa-project.org On Fri, Jul 14, 2017 at 03:36:57PM +0200, Linus Walleij wrote: > On Wed, Jul 12, 2017 at 5:55 PM, Johan Hovold wrote: > > > This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI > > assignments"), which seems to have been based on a misunderstanding and > > prevents the platform driver callbacks from being made (e.g. to > > preallocate DMA memory). > > > > The real culprit for the warnings about attempts to create duplicate > > procfs entries was commit 99b04f4c4051 ("ASoC: add Component level > > pcm_new/pcm_free" that broke PCM creation on systems that use more than > > one platform component. > > > > Fixes: f1013cdeeeb9 ("ASoC: ux500: drop platform DAI assignments") > > Cc: stable # 4.11 > > Cc: Linus Walleij > > Signed-off-by: Johan Hovold > > Reviewed-by: Linus Walleij > Tested-by: Linus Walleij > > These static assignments should go away, but not for the wrong reason. > So this patch is fully in order given the source of the bug. I assume you'll still need the of-related bits though (platform_of_node) even if you eventually make this driver use DT-instantiation only. Thanks again, Johan