From: Vinod Koul <vinod.koul@intel.com>
To: Pradeep Tewani <pradeep.d.tewani@intel.com>
Cc: tiwai@suse.de, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] ASoC: Intel: board: Add Geminilake platform support
Date: Tue, 18 Jul 2017 13:41:06 +0530 [thread overview]
Message-ID: <20170718081105.GR3053@localhost> (raw)
In-Reply-To: <1500304529-25804-2-git-send-email-pradeep.d.tewani@intel.com>
On Mon, Jul 17, 2017 at 08:45:28PM +0530, Pradeep Tewani wrote:
> +static struct snd_soc_card geminilake_rt298 = {
> + .name = "geminilake-rt298",
> + .owner = THIS_MODULE,
Do we need this, i though core set it up?
> static int broxton_audio_probe(struct platform_device *pdev)
> {
> struct bxt_rt286_private *ctx;
> + struct snd_soc_card *card =
> + (struct snd_soc_card *)pdev->id_entry->driver_data;
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(broxton_rt298_dais); i++) {
> + if (!strcmp(card->dai_link[i].codec_name, "i2c-INT343A:00")) {
> + if (!strcmp(card->name, "broxton-rt298")) {
can we use strncmp pls
--
~Vinod
next prev parent reply other threads:[~2017-07-18 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 15:15 [PATCH 0/2] ASoC: Intel: Skylake: Enable hdmi for GLK Pradeep Tewani
2017-07-17 15:15 ` [PATCH 1/2] ASoC: Intel: board: Add Geminilake platform support Pradeep Tewani
2017-07-18 8:11 ` Vinod Koul [this message]
2017-07-17 15:15 ` [PATCH 2/2] ASoC: hdac_hdmi: Add the vendor nid for Geminilake HDMI Pradeep Tewani
2017-07-20 12:23 ` Applied "ASoC: hdac_hdmi: Add the vendor nid for Geminilake HDMI" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718081105.GR3053@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=pradeep.d.tewani@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).