From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Takashi Iwai <tiwai@suse.com>, stable <stable@vger.kernel.org>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments"
Date: Tue, 18 Jul 2017 10:21:18 +0200 [thread overview]
Message-ID: <20170718082118.GG29638@localhost> (raw)
In-Reply-To: <20170717145127.ke5o65as35itamaf@sirena.org.uk>
On Mon, Jul 17, 2017 at 03:51:27PM +0100, Mark Brown wrote:
> On Wed, Jul 12, 2017 at 05:55:30PM +0200, Johan Hovold wrote:
> > This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI
> > assignments"), which seems to have been based on a misunderstanding and
> > prevents the platform driver callbacks from being made (e.g. to
> > preallocate DMA memory).
>
> Please submit patches using subject lines reflecting the style for the
> subsystem. This makes it easier for people to identify relevant
> patches. Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
I try to, but reverts are special as the default commit summary tend to
already contain the subsystem prefix and some maintainers find that
sufficient (or even preferred as this also makes reverts stand out more
clearly).
But now I know your preference, and thanks for fixing it up this time
before applying.
Johan
next prev parent reply other threads:[~2017-07-18 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 15:55 [PATCH 1/2] ASoC: fix pcm-creation regression Johan Hovold
2017-07-12 15:55 ` [PATCH 2/2] Revert "ASoC: ux500: drop platform DAI assignments" Johan Hovold
2017-07-14 13:36 ` Linus Walleij
2017-07-17 8:07 ` Johan Hovold
2017-07-17 14:51 ` Mark Brown
2017-07-18 8:21 ` Johan Hovold [this message]
2017-07-18 10:06 ` Mark Brown
2017-07-18 10:36 ` Johan Hovold
2017-07-18 12:59 ` Mark Brown
2017-07-17 16:05 ` Applied "ASoC: ux500: Restore platform DAI assignments" to the asoc tree Mark Brown
2017-07-14 13:35 ` [PATCH 1/2] ASoC: fix pcm-creation regression Linus Walleij
2017-07-17 8:03 ` Johan Hovold
2017-07-17 16:05 ` Applied "ASoC: fix pcm-creation regression" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718082118.GG29638@localhost \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).