From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
perex@perex.cz, tiwai@suse.com, sbkim73@samsung.com,
lgirdwood@gmail.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree
Date: Wed, 26 Jul 2017 18:13:18 +0200 [thread overview]
Message-ID: <20170726161318.GA4093@kozik-book> (raw)
In-Reply-To: <20170726160700.tffy72uwhw4hilhw@sirena.org.uk>
On Wed, Jul 26, 2017 at 05:07:00PM +0100, Mark Brown wrote:
> On Wed, Jul 26, 2017 at 05:46:42PM +0200, Krzysztof Kozlowski wrote:
>
> > Mark, this is the patch still discussed. It does not handle the error
> > correctly. I think it should be dropped.
>
> Ugh, is that the same patch? Sorry, got lost in the big series. Now
> I've applied it I'd rather do incremental updates to it if possible but
> let's see if that can be done promptly...
Fixing this is not that critical because error path of s3c2412_i2s_probe()
already did not clean up what was needed. So merely we are duplicating
same wrong pattern.
I can prepare an incremental fix tomorrow or the day after, so, Arvind,
if you can do it faster, please go ahead.
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-07-26 16:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 10:14 [PATCH 00/11] Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 10:14 ` [PATCH 01/11] ASoC: samsung: s3c2412: " Arvind Yadav
2017-07-25 17:43 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-26 15:46 ` Krzysztof Kozlowski
2017-07-26 16:07 ` Mark Brown
2017-07-26 16:13 ` Krzysztof Kozlowski [this message]
2017-07-25 10:14 ` [PATCH 02/11] ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 17:50 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 03/11] ASoC: samsung: pcm: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 17:51 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: pcm: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 17:58 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: i2s: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 18:01 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: spdif: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 06/11] ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare Arvind Yadav
2017-07-26 14:16 ` Applied "ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 07/11] ASoC: jz4740: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-26 14:16 ` Applied "ASoC: jz4740: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726161318.GA4093@kozik-book \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).