From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx
Date: Thu, 27 Jul 2017 19:13:37 +0200 [thread overview]
Message-ID: <20170727171338.13300-3-krzk@kernel.org> (raw)
In-Reply-To: <20170727171338.13300-1-krzk@kernel.org>
The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't
probably fatal, because for SoC clocks this is usually no-op, but for
correctness this clock should be prepared.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. New patch
---
sound/soc/samsung/s3c-i2s-v2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index 9b28046eea8e..3894bda06ebb 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai,
return -ENOENT;
}
- clk_enable(i2s->iis_pclk);
+ clk_prepare_enable(i2s->iis_pclk);
/* Mark ourselves as in TXRX mode so we can run through our cleanup
* process without warnings. */
--
2.11.0
next prev parent reply other threads:[~2017-07-27 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 17:13 [RFT v2 0/3] ASoC: samsung: s3c24xx: Fixes for error paths Krzysztof Kozlowski
2017-07-27 17:13 ` [RFT v2 1/3] ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure Krzysztof Kozlowski
2017-07-28 4:39 ` Arvind Yadav
2017-07-27 17:13 ` Krzysztof Kozlowski [this message]
2017-07-28 4:41 ` [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Arvind Yadav
2017-07-28 5:44 ` Krzysztof Kozlowski
2017-07-28 6:05 ` Arvind Yadav
2017-07-28 10:18 ` Applied "ASoC: samsung: Add missing prepare for iis clock of s3c24xx" to the asoc tree Mark Brown
2017-07-27 17:13 ` [RFT v2 3/3] ASoC: samsung: Add proper error paths to s3c24xx I2S driver Krzysztof Kozlowski
2017-07-28 4:47 ` Arvind Yadav
2017-07-28 10:17 ` Applied "ASoC: samsung: Add proper error paths to s3c24xx I2S driver" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727171338.13300-3-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).