From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Stefan Agner <stefan@agner.ch>
Cc: timur@tabi.org, Xiubo.Lee@gmail.com, fabio.estevam@nxp.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_asrc: protect macro argument
Date: Mon, 7 Aug 2017 00:08:07 -0700 [thread overview]
Message-ID: <20170807070806.GA8208@Asurada> (raw)
In-Reply-To: <20170807063657.12581-1-stefan@agner.ch>
On Sun, Aug 06, 2017 at 11:36:57PM -0700, Stefan Agner wrote:
> Protect macro argument with parentheses to avoid ambiguity.
> This fixes a warning seen with clang:
> warning: logical not is only applied to the left hand side of this comparison
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thanks
> ---
> sound/soc/fsl/fsl_asrc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_asrc.h b/sound/soc/fsl/fsl_asrc.h
> index 0f163abe4ba3..ec33dab4b909 100644
> --- a/sound/soc/fsl/fsl_asrc.h
> +++ b/sound/soc/fsl/fsl_asrc.h
> @@ -57,7 +57,7 @@
> #define REG_ASRDOC 0x74
> #define REG_ASRDI(i) (REG_ASRDIA + (i << 3))
> #define REG_ASRDO(i) (REG_ASRDOA + (i << 3))
> -#define REG_ASRDx(x, i) (x == IN ? REG_ASRDI(i) : REG_ASRDO(i))
> +#define REG_ASRDx(x, i) ((x) == IN ? REG_ASRDI(i) : REG_ASRDO(i))
>
> #define REG_ASRIDRHA 0x80
> #define REG_ASRIDRLA 0x84
> --
> 2.13.3
>
next prev parent reply other threads:[~2017-08-07 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 6:36 [PATCH] ASoC: fsl_asrc: protect macro argument Stefan Agner
2017-08-07 7:08 ` Nicolin Chen [this message]
2017-12-06 13:53 ` Stefan Agner
2017-12-06 14:11 ` Mark Brown
2017-12-06 14:25 ` Stefan Agner
2017-12-06 14:39 ` Mark Brown
2017-12-06 15:03 ` Stefan Agner
2017-12-06 15:29 ` Applied "ASoC: fsl_asrc: protect macro argument" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807070806.GA8208@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).