From: Banajit Goswami <bgoswami@codeaurora.org>
To: Peng Donglin <dolinux.peng@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com,
broonie@kernel.org
Subject: Re: [PATCH 09/12] ASoC: qcom: Remove unnecessary function call
Date: Mon, 21 Aug 2017 01:09:49 -0700 [thread overview]
Message-ID: <20170821080949.GB8000@codeaurora.org> (raw)
In-Reply-To: <1503207898-16378-1-git-send-email-dolinux.peng@gmail.com>
On Sun, Aug 20, 2017 at 01:44:58PM +0800, Peng Donglin wrote:
> First of all,the address of pdev->dev is assigned to card->dev,then
> the function platform_set_drvdata copies the value the variable card
> to pdev->dev.driver_data, but when calling snd_soc_register_card,the
> function dev_set_drvdata(card->dev, card) will also do the same copy
> operation,so i think that the former copy operation can be removed.
>
> Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
Acked-by: Banajit Goswami <bgoswami@codeaurora.org>
> ---
> sound/soc/qcom/storm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
> index c5207af..a9fa972 100644
> --- a/sound/soc/qcom/storm.c
> +++ b/sound/soc/qcom/storm.c
> @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> card->dev = &pdev->dev;
> - platform_set_drvdata(pdev, card);
>
> ret = snd_soc_of_parse_card_name(card, "qcom,model");
> if (ret) {
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2017-08-21 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 5:44 [PATCH 09/12] ASoC: qcom: Remove unnecessary function call Peng Donglin
2017-08-21 8:09 ` Banajit Goswami [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821080949.GB8000@codeaurora.org \
--to=bgoswami@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dolinux.peng@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).