* [PATCH 09/12] ASoC: qcom: Remove unnecessary function call
@ 2017-08-20 5:44 Peng Donglin
2017-08-21 8:09 ` Banajit Goswami
0 siblings, 1 reply; 2+ messages in thread
From: Peng Donglin @ 2017-08-20 5:44 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, plai, bgoswami
Cc: alsa-devel, linux-kernel, Peng Donglin
First of all,the address of pdev->dev is assigned to card->dev,then
the function platform_set_drvdata copies the value the variable card
to pdev->dev.driver_data, but when calling snd_soc_register_card,the
function dev_set_drvdata(card->dev, card) will also do the same copy
operation,so i think that the former copy operation can be removed.
Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
---
sound/soc/qcom/storm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
index c5207af..a9fa972 100644
--- a/sound/soc/qcom/storm.c
+++ b/sound/soc/qcom/storm.c
@@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)
return -ENOMEM;
card->dev = &pdev->dev;
- platform_set_drvdata(pdev, card);
ret = snd_soc_of_parse_card_name(card, "qcom,model");
if (ret) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 09/12] ASoC: qcom: Remove unnecessary function call
2017-08-20 5:44 [PATCH 09/12] ASoC: qcom: Remove unnecessary function call Peng Donglin
@ 2017-08-21 8:09 ` Banajit Goswami
0 siblings, 0 replies; 2+ messages in thread
From: Banajit Goswami @ 2017-08-21 8:09 UTC (permalink / raw)
To: Peng Donglin; +Cc: alsa-devel, linux-kernel, plai, tiwai, lgirdwood, broonie
On Sun, Aug 20, 2017 at 01:44:58PM +0800, Peng Donglin wrote:
> First of all,the address of pdev->dev is assigned to card->dev,then
> the function platform_set_drvdata copies the value the variable card
> to pdev->dev.driver_data, but when calling snd_soc_register_card,the
> function dev_set_drvdata(card->dev, card) will also do the same copy
> operation,so i think that the former copy operation can be removed.
>
> Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
Acked-by: Banajit Goswami <bgoswami@codeaurora.org>
> ---
> sound/soc/qcom/storm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c
> index c5207af..a9fa972 100644
> --- a/sound/soc/qcom/storm.c
> +++ b/sound/soc/qcom/storm.c
> @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> card->dev = &pdev->dev;
> - platform_set_drvdata(pdev, card);
>
> ret = snd_soc_of_parse_card_name(card, "qcom,model");
> if (ret) {
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-21 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 5:44 [PATCH 09/12] ASoC: qcom: Remove unnecessary function call Peng Donglin
2017-08-21 8:09 ` Banajit Goswami
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).