From: Vinod Koul <vinod.koul@intel.com>
To: Naveen M <naveen.m@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH v2] ASoC: Intel: kbl: Add map for Maxim IV Feedback
Date: Wed, 23 Aug 2017 06:41:07 +0530 [thread overview]
Message-ID: <20170823011107.GC3053@localhost> (raw)
In-Reply-To: <1503393562-31613-1-git-send-email-naveen.m@intel.com>
hi Naveen,
On Tue, Aug 22, 2017 at 02:49:22PM +0530, Naveen M wrote:
> MAX98927 provides IV feedback on the capture widget.
> Here we are connecting the capture widget to SSP0_RX and
> SSP0_RX to the algorithm running on host.
This is good
>
> v2: rebased on newer kernel (d46b182)
But this is not, version info is useful for review but useless for changelog
This should be after s-ob lines
>
> Signed-off-by: Naveen M <naveen.m@intel.com>
> Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
--
here put version line, its skipped while applying
>
> diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c
> index c144214..8d2a1c0 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c
> @@ -107,6 +107,11 @@ enum {
> { "hs_in", NULL, "ssp1 Rx" },
> { "ssp1 Rx", NULL, "AIF Capture" },
>
> + /* IV feedback path */
> + { "codec0_fb_in", NULL, "ssp0 Rx"},
> + { "ssp0 Rx", NULL, "Left HiFi Capture" },
> + { "ssp0 Rx", NULL, "Right HiFi Capture" },
> +
> /* DMIC */
> { "dmic01_hifi", NULL, "DMIC01 Rx" },
> { "DMIC01 Rx", NULL, "DMIC AIF" },
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index c2ef538..8d19da9 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -119,6 +119,11 @@ enum {
> { "codec1_in", NULL, "ssp0 Rx" },
> { "ssp0 Rx", NULL, "AIF1 Capture" },
>
> + /* IV feedback path */
> + { "codec0_fb_in", NULL, "ssp0 Rx"},
> + { "ssp0 Rx", NULL, "Left HiFi Capture" },
> + { "ssp0 Rx", NULL, "Right HiFi Capture" },
> +
> /* DMIC */
> { "DMIC1L", NULL, "DMIC" },
> { "DMIC1R", NULL, "DMIC" },
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
~Vinod
next prev parent reply other threads:[~2017-08-23 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 9:19 [PATCH v2] ASoC: Intel: kbl: Add map for Maxim IV Feedback Naveen M
2017-08-23 1:11 ` Vinod Koul [this message]
2017-08-29 19:29 ` Applied "ASoC: Intel: kbl: Add map for Maxim IV Feedback" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823011107.GC3053@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox