alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jaechul Lee <jcsing.lee@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	galaxyra@gmail.com, linux-samsung-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jaechul Lee <jcsing.lee@samsung.com>
Subject: [PATCH 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called
Date: Mon, 28 Aug 2017 19:01:02 +0900	[thread overview]
Message-ID: <20170828100102.17591-4-jcsing.lee@samsung.com> (raw)
In-Reply-To: <20170828100102.17591-1-jcsing.lee@samsung.com>

devm_gpiod_get is called with GPIOF_OUT_INIT_LOW but the function doesn't
allow the parameters. Unluckily, GPIOF_OUT_INIT_LOW is same value as
GPIOD_IN so it works like input gpio.

Muted stream comes up when I try recording some sounds on TM2. mic-bias
gpiod state can't be changed because the gpiod is created with the invalid
parameter. The gpio should be set GPIOD_OUT_HIGH.

Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
---
 sound/soc/samsung/tm2_wm5110.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
index f467ad06e827..76abe45ed537 100644
--- a/sound/soc/samsung/tm2_wm5110.c
+++ b/sound/soc/samsung/tm2_wm5110.c
@@ -439,8 +439,7 @@ static int tm2_probe(struct platform_device *pdev)
 	snd_soc_card_set_drvdata(card, priv);
 	card->dev = dev;
 
-	priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias",
-						GPIOF_OUT_INIT_LOW);
+	priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", GPIOD_OUT_HIGH);
 	if (IS_ERR(priv->gpio_mic_bias)) {
 		dev_err(dev, "Failed to get mic bias gpio\n");
 		return PTR_ERR(priv->gpio_mic_bias);
-- 
2.14.1

  parent reply	other threads:[~2017-08-28 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170828100105epcas2p459f6a7c311d08c965f429bf1f8d56a31@epcas2p4.samsung.com>
2017-08-28 10:00 ` [PATCH 0/3] Fix capture devices functionality on TM2 Jaechul Lee
     [not found]   ` <CGME20170828100105epcas2p18b821aec5caf1d690c33c2b1426d1a17@epcas2p1.samsung.com>
2017-08-28 10:01     ` [PATCH 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Jaechul Lee
2017-09-01 10:17       ` Mark Brown
2017-09-03 20:01       ` Krzysztof Kozlowski
     [not found]   ` <CGME20170828100105epcas2p483d90d281f69aafa01d9acacc40c9da5@epcas2p4.samsung.com>
2017-08-28 10:01     ` [PATCH 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links Jaechul Lee
     [not found]   ` <CGME20170828100105epcas2p3b528f17ba89532835e9b1735a0016215@epcas2p3.samsung.com>
2017-08-28 10:01     ` Jaechul Lee [this message]
2017-09-03 20:07       ` [PATCH 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Krzysztof Kozlowski
2017-09-19 14:59       ` Applied "ASoC: samsung: Fix invalid argument when devm_gpiod_get is called" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828100102.17591-4-jcsing.lee@samsung.com \
    --to=jcsing.lee@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=galaxyra@gmail.com \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).