From: Jaechul Lee <jcsing.lee@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
galaxyra@gmail.com, Jaechul Lee <jcsing.lee@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: [PATCH v2 0/3] Fix capture devices functionality on TM2
Date: Wed, 06 Sep 2017 10:04:12 +0900 [thread overview]
Message-ID: <20170906010415.26952-1-jcsing.lee@samsung.com> (raw)
In-Reply-To: CGME20170906010417epcas2p2ba8d740d4d071b6479a05b31f81c8b46@epcas2p2.samsung.com
Hello,
This patchset makes capture functionality working on TM2.
Capture devices can't be detected because I2S doesn't have appropriate dai
name. Therefore, TM2 will select unexpected cpu dai which is named
"i2s-samsung-sec" that doesn't have a capture functionality.
In samsung I2S driver, it tries to register two components without
specific name. The driver finally has components having same name: dai
name as well. As a result, dai_link doesn't have enough information to
select cpu_dai properly.
Changes in v2:
- defined SAMSUNG_I2S_DAI_* in i2s.h and removed duplicated code
- modified commit message about invalid parameter that Krzystof mentioned
- rebased code because of conflicts in i2s.c
Jaechul Lee (3):
ASoC: samsung: i2s: Use specific name for i2s dais
ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links
ASoC: samsung: Fix invalid argument when devm_gpiod_get is called
sound/soc/samsung/i2s.c | 4 ++++
sound/soc/samsung/i2s.h | 3 +++
sound/soc/samsung/tm2_wm5110.c | 7 ++++---
3 files changed, 11 insertions(+), 3 deletions(-)
--
2.14.1
next parent reply other threads:[~2017-09-06 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170906010417epcas2p2ba8d740d4d071b6479a05b31f81c8b46@epcas2p2.samsung.com>
2017-09-06 1:04 ` Jaechul Lee [this message]
[not found] ` <CGME20170906010417epcas2p208db637d89a670d01fa3dbeb78ff0da0@epcas2p2.samsung.com>
2017-09-06 1:04 ` [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Jaechul Lee
2017-09-08 16:43 ` Krzysztof Kozlowski
2017-09-19 14:59 ` Applied "ASoC: samsung: i2s: Use specific name for i2s dais" to the asoc tree Mark Brown
[not found] ` <CGME20170906010417epcas1p2b3460cf27e35e64f5e35fad98f554108@epcas1p2.samsung.com>
2017-09-06 1:04 ` [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links Jaechul Lee
2017-09-08 16:45 ` Krzysztof Kozlowski
2017-09-19 14:59 ` Applied "ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links" to the asoc tree Mark Brown
[not found] ` <CGME20170906010417epcas2p1fa15cc68a8fb034f087b8103f6767f29@epcas2p1.samsung.com>
2017-09-06 1:04 ` [PATCH v2 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Jaechul Lee
2017-09-08 16:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906010415.26952-1-jcsing.lee@samsung.com \
--to=jcsing.lee@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=galaxyra@gmail.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).