From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 3/3] ASoC: intel: Kill BUG_ON() usage
Date: Fri, 8 Sep 2017 14:14:05 +0530 [thread overview]
Message-ID: <20170908084404.GD3053@localhost> (raw)
In-Reply-To: <20170907085918.4496-4-tiwai@suse.de>
On Thu, Sep 07, 2017 at 10:59:18AM +0200, Takashi Iwai wrote:
> Don't use BUG_ON() for a non-critical sanity check on production
> systems. This patch either removes useless BUG_ON() calls.
Acked-By: Vinod Koul <vinod.koul@intel.com>
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/soc/intel/atom/sst/sst_loader.c | 1 -
> sound/soc/intel/atom/sst/sst_stream.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_loader.c b/sound/soc/intel/atom/sst/sst_loader.c
> index 33917146d9c4..a686eef2cf7f 100644
> --- a/sound/soc/intel/atom/sst/sst_loader.c
> +++ b/sound/soc/intel/atom/sst/sst_loader.c
> @@ -415,7 +415,6 @@ int sst_load_fw(struct intel_sst_drv *sst_drv_ctx)
> return ret_val;
> }
>
> - BUG_ON(!sst_drv_ctx->fw_in_mem);
> block = sst_create_block(sst_drv_ctx, 0, FW_DWNL_ID);
> if (block == NULL)
> return -ENOMEM;
> diff --git a/sound/soc/intel/atom/sst/sst_stream.c b/sound/soc/intel/atom/sst/sst_stream.c
> index 83d8dda15233..65e257b17a7e 100644
> --- a/sound/soc/intel/atom/sst/sst_stream.c
> +++ b/sound/soc/intel/atom/sst/sst_stream.c
> @@ -45,7 +45,6 @@ int sst_alloc_stream_mrfld(struct intel_sst_drv *sst_drv_ctx, void *params)
> void *data = NULL;
>
> dev_dbg(sst_drv_ctx->dev, "Enter\n");
> - BUG_ON(!params);
>
> str_params = (struct snd_sst_params *)params;
> memset(&alloc_param, 0, sizeof(alloc_param));
> --
> 2.14.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
~Vinod
next prev parent reply other threads:[~2017-09-08 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 8:59 [PATCH 0/3] ASoC: Kill BUG_ON() usages Takashi Iwai
2017-09-07 8:59 ` [PATCH 1/3] ASoC: tas571x: Kill BUG_ON() usage Takashi Iwai
2017-09-20 11:47 ` Applied "ASoC: tas571x: Kill BUG_ON() usage" to the asoc tree Mark Brown
2017-09-07 8:59 ` [PATCH 2/3] ASoC: davinci: Kill BUG_ON() usage Takashi Iwai
2017-09-20 11:47 ` Applied "ASoC: davinci: Kill BUG_ON() usage" to the asoc tree Mark Brown
2017-09-07 8:59 ` [PATCH 3/3] ASoC: intel: Kill BUG_ON() usage Takashi Iwai
2017-09-08 8:44 ` Vinod Koul [this message]
2017-09-20 11:47 ` Applied "ASoC: intel: Kill BUG_ON() usage" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908084404.GD3053@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).