alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jaechul Lee <jcsing.lee@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org, galaxyra@gmail.com,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais
Date: Fri, 8 Sep 2017 18:43:30 +0200	[thread overview]
Message-ID: <20170908164330.pw3fxcxvrnajlaox@kozik-lap> (raw)
In-Reply-To: <20170906010415.26952-2-jcsing.lee@samsung.com>

On Wed, Sep 06, 2017 at 10:04:13AM +0900, Jaechul Lee wrote:
> Add specific dais name when components are registered. Component and dai
> name will follow their parent dev name, if the name isn't described.  In
> case of this driver, each dais will have same name like '11440000.i2s0' by
> fmt_single_name function.
> 
> The problem having same name is that TM2 machine driver can't detect
> capture devices correctly. Machine driver doesn't know which one is proper
> to use for cpu dai. The driver just selects to use 'samsung-i2c-sec' that
> doesn't have capture functionality because the component of
> samsung-i2s-sec is located in the first of the component_list.
> 
> I add dai name like 'samsung-i2s', 'samsung-i2s-sec' for each dais. The
> reason why adding dai id to 1 is that it doesn't allow to use particular
> dai name in case of when I use 0 for dai id.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> ---
>  sound/soc/samsung/i2s.c | 4 ++++
>  sound/soc/samsung/i2s.h | 3 +++
>  2 files changed, 7 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

  reply	other threads:[~2017-09-08 16:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170906010417epcas2p2ba8d740d4d071b6479a05b31f81c8b46@epcas2p2.samsung.com>
2017-09-06  1:04 ` [PATCH v2 0/3] Fix capture devices functionality on TM2 Jaechul Lee
     [not found]   ` <CGME20170906010417epcas2p208db637d89a670d01fa3dbeb78ff0da0@epcas2p2.samsung.com>
2017-09-06  1:04     ` [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Jaechul Lee
2017-09-08 16:43       ` Krzysztof Kozlowski [this message]
2017-09-19 14:59       ` Applied "ASoC: samsung: i2s: Use specific name for i2s dais" to the asoc tree Mark Brown
     [not found]   ` <CGME20170906010417epcas1p2b3460cf27e35e64f5e35fad98f554108@epcas1p2.samsung.com>
2017-09-06  1:04     ` [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links Jaechul Lee
2017-09-08 16:45       ` Krzysztof Kozlowski
2017-09-19 14:59       ` Applied "ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links" to the asoc tree Mark Brown
     [not found]   ` <CGME20170906010417epcas2p1fa15cc68a8fb034f087b8103f6767f29@epcas2p1.samsung.com>
2017-09-06  1:04     ` [PATCH v2 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Jaechul Lee
2017-09-08 16:46       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170908164330.pw3fxcxvrnajlaox@kozik-lap \
    --to=krzk@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=galaxyra@gmail.com \
    --cc=jcsing.lee@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).