From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Date: Fri, 8 Sep 2017 18:43:30 +0200 Message-ID: <20170908164330.pw3fxcxvrnajlaox@kozik-lap> References: <20170906010415.26952-1-jcsing.lee@samsung.com> <20170906010415.26952-2-jcsing.lee@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20170906010415.26952-2-jcsing.lee@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Jaechul Lee Cc: Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, galaxyra@gmail.com, Chanwoo Choi List-Id: alsa-devel@alsa-project.org On Wed, Sep 06, 2017 at 10:04:13AM +0900, Jaechul Lee wrote: > Add specific dais name when components are registered. Component and dai > name will follow their parent dev name, if the name isn't described. In > case of this driver, each dais will have same name like '11440000.i2s0' by > fmt_single_name function. > > The problem having same name is that TM2 machine driver can't detect > capture devices correctly. Machine driver doesn't know which one is proper > to use for cpu dai. The driver just selects to use 'samsung-i2c-sec' that > doesn't have capture functionality because the component of > samsung-i2s-sec is located in the first of the component_list. > > I add dai name like 'samsung-i2s', 'samsung-i2s-sec' for each dais. The > reason why adding dai id to 1 is that it doesn't allow to use particular > dai name in case of when I use 0 for dai id. > > Signed-off-by: Jaechul Lee > --- > sound/soc/samsung/i2s.c | 4 ++++ > sound/soc/samsung/i2s.h | 3 +++ > 2 files changed, 7 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof