From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jaechul Lee <jcsing.lee@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, galaxyra@gmail.com,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links
Date: Fri, 8 Sep 2017 18:45:12 +0200 [thread overview]
Message-ID: <20170908164512.5wwrn2gknfzzb6uy@kozik-lap> (raw)
In-Reply-To: <20170906010415.26952-3-jcsing.lee@samsung.com>
On Wed, Sep 06, 2017 at 10:04:14AM +0900, Jaechul Lee wrote:
> Add specific cpu_dai_name to dai_link because samsung i2s driver registers
> two dais and components. Selecting one of them clearly is needed more
> information like cpu_dai_name, of_node. The reason why the dai_links have
> to use 'samsung-i2s' for cpu_dai is that 'samsung-i2s-sec' doesn't have a
> capture functionality.
>
> Without this code, cpu_dai will be selected the first one of the
> component_list. For example, if I describe nothing to cpu_dai_name,
> 'samsung-i2s-sec' might be selected to HiFi Primay.
>
> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
> ---
> sound/soc/samsung/tm2_wm5110.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-09-08 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170906010417epcas2p2ba8d740d4d071b6479a05b31f81c8b46@epcas2p2.samsung.com>
2017-09-06 1:04 ` [PATCH v2 0/3] Fix capture devices functionality on TM2 Jaechul Lee
2017-09-06 1:04 ` [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais Jaechul Lee
2017-09-08 16:43 ` Krzysztof Kozlowski
2017-09-19 14:59 ` Applied "ASoC: samsung: i2s: Use specific name for i2s dais" to the asoc tree Mark Brown
2017-09-06 1:04 ` [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links Jaechul Lee
2017-09-08 16:45 ` Krzysztof Kozlowski [this message]
2017-09-19 14:59 ` Applied "ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai_links" to the asoc tree Mark Brown
2017-09-06 1:04 ` [PATCH v2 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Jaechul Lee
2017-09-08 16:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908164512.5wwrn2gknfzzb6uy@kozik-lap \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=galaxyra@gmail.com \
--cc=jcsing.lee@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).