From: Vinod Koul <vinod.koul@intel.com>
To: Naveen M <naveen.m@intel.com>
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH] ASoC: Intel: Headset button support in kabylake machine driver
Date: Mon, 18 Sep 2017 09:07:40 +0530 [thread overview]
Message-ID: <20170918033740.GG30097@localhost> (raw)
In-Reply-To: <1505463201-6419-1-git-send-email-naveen.m@intel.com>
On Fri, Sep 15, 2017 at 01:43:21PM +0530, Naveen M wrote:
> Patch adds headset button support for kabylake machine driver
> (kbl_rt5663_max98927).
Acked-By: Vinod Koul <vinod.koul@intel.com>
> Signed-off-by: Naveen M <naveen.m@intel.com>
>
> diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c
> index 7f76074..e45b6fe 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c
> @@ -17,6 +17,7 @@
> * GNU General Public License for more details.
> */
>
> +#include <linux/input.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <sound/core.h>
> @@ -208,6 +209,7 @@ static int kabylake_rt5663_codec_init(struct snd_soc_pcm_runtime *rtd)
> int ret;
> struct kbl_rt5663_private *ctx = snd_soc_card_get_drvdata(rtd->card);
> struct snd_soc_codec *codec = rtd->codec;
> + struct snd_soc_jack *jack;
>
> /*
> * Headset buttons map to the google Reference headset.
> @@ -221,6 +223,13 @@ static int kabylake_rt5663_codec_init(struct snd_soc_pcm_runtime *rtd)
> dev_err(rtd->dev, "Headset Jack creation failed %d\n", ret);
> return ret;
> }
> +
> + jack = &ctx->kabylake_headset;
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
> +
> rt5663_set_jack_detect(codec, &ctx->kabylake_headset);
> return ret;
> }
> --
> 1.9.1
>
--
~Vinod
next prev parent reply other threads:[~2017-09-18 3:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:13 [PATCH] ASoC: Intel: Headset button support in kabylake machine driver Naveen M
2017-09-18 3:37 ` Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-21 19:26 Harsha Priya
2017-08-22 5:15 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918033740.GG30097@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).