From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
Date: Tue, 10 Oct 2017 17:18:46 +0200 [thread overview]
Message-ID: <20171010171846.509f399e@karo-electronics.de> (raw)
In-Reply-To: <1507646944.2398.1.camel@pengutronix.de>
Hi,
On Tue, 10 Oct 2017 16:49:04 +0200 Lucas Stach wrote:
> Hi Lothar,
>
> Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Waßmann:
> > Hi,
> >
> > the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
> > introduced a regression on the Ka-Ro TX series modules (and possibly
> > other hardware as well).
> >
> > The problem is, that this commit restricts the supported sound
> > formats
> > to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the
> > patch. Therefore aplay fails with the following error messages, when
> > trying to play a sound file with S16_LE format:
> > > ALSA lib alsa-lib-
> > > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave
> > > PCM not usable
> > > aplay: set_params:1204: Broken configuration for this PCM: no
> > > configurations available
> >
> > This is with the simple-sound-card driver as well as the imx-sgtl5000
> > driver.
> >
> > Can someone tell me on what hardware and with what software has this
> > patch been tested?
>
> My primary test hardware was the zii-rdu2 board, the DTS for this board
> can be found in recent mainline kernels.
>
> Userspace is based on pulseaudio, which may mask the regression by
> resampling to the supported format. Sorry about that.
>
> From my understanding of the code, it should be possible to fix the
> regression without reverting this patch by setting
> SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in
> fsl_ssi.
>
I tried that, but then I get DMA timeouts.
I circumvented the problem by changing my /etc/asound.conf to use the
only supported sample format. So, if nobody else has a problem, there
is no need to revert the patch or apply additional modifications to the
driver.
Lothar Waßmann
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-10-10 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 8:36 regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") Lothar Waßmann
2017-10-10 14:49 ` Lucas Stach
2017-10-10 15:18 ` Lothar Waßmann [this message]
2017-10-12 15:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010171846.509f399e@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).