alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Vinod Koul <vinod.koul@intel.com>, dmaengine@vger.kernel.org
Cc: alsa-devel@alsa-project.org, patchwork-lst@pengutronix.de,
	broonie@kernel.org, kernel@pengutronix.de,
	peter.seiderer.ext@zeiss.com, LW@KARO-electronics.de
Subject: [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths
Date: Fri, 13 Oct 2017 12:43:46 +0200	[thread overview]
Message-ID: <20171013104346.16818-1-l.stach@pengutronix.de> (raw)

The commit [1] which changed imx-pcm-dma to derive the pcm_config from the
attached dmaengine introduced a regression on the supported sample formats,
as imx-sdma doesn't properly advertise all the supported slave bus widths.

Fix this to restore full functionality of the imx sound subsystem.

[1] 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/dma/imx-sdma.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index a67ec1bdc4e0..e374183f19d0 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1851,8 +1851,12 @@ static int sdma_probe(struct platform_device *pdev)
 	sdma->dma_device.device_prep_dma_cyclic = sdma_prep_dma_cyclic;
 	sdma->dma_device.device_config = sdma_config;
 	sdma->dma_device.device_terminate_all = sdma_disable_channel_with_delay;
-	sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
-	sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
+	sdma->dma_device.src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
+					   BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |
+					   BIT(DMA_SLAVE_BUSWIDTH_1_BYTE);
+	sdma->dma_device.dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) |
+					   BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |
+					   BIT(DMA_SLAVE_BUSWIDTH_1_BYTE);
 	sdma->dma_device.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
 	sdma->dma_device.residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
 	sdma->dma_device.device_issue_pending = sdma_issue_pending;
-- 
2.11.0

             reply	other threads:[~2017-10-13 10:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 10:43 Lucas Stach [this message]
2017-10-13 11:23 ` [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths Lothar Waßmann
2017-10-13 11:25 ` Mark Brown
2017-10-13 11:35   ` Lucas Stach
2017-10-13 14:39     ` Mark Brown
2017-10-13 14:50       ` Lucas Stach
2017-10-13 17:13         ` Mark Brown
2017-10-16  6:28           ` Vinod Koul
2017-10-16  9:19             ` Mark Brown
2017-10-16  6:51 ` Vinod Koul
2017-10-16  7:26   ` Lucas Stach
2017-10-31 12:13 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013104346.16818-1-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=LW@KARO-electronics.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=patchwork-lst@pengutronix.de \
    --cc=peter.seiderer.ext@zeiss.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).