* [PATCH] ALSA: ens137x: remove redundant variable result
@ 2017-10-15 21:16 Colin King
2017-10-16 11:37 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-15 21:16 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Bhumika Goyal, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable result is being assigned a value from a calculation
however the variable is never read, so this redundant variable
can be removed.
Cleans up clang warning: Value stored to 'result' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/pci/ens1370.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
index d4cd6451fdca..39f79a6b5283 100644
--- a/sound/pci/ens1370.c
+++ b/sound/pci/ens1370.c
@@ -732,7 +732,7 @@ static void snd_es1371_codec_wait(struct snd_ac97 *ac97)
static void snd_es1371_adc_rate(struct ensoniq * ensoniq, unsigned int rate)
{
- unsigned int n, truncm, freq, result;
+ unsigned int n, truncm, freq;
mutex_lock(&ensoniq->src_mutex);
n = rate / 3000;
@@ -740,7 +740,6 @@ static void snd_es1371_adc_rate(struct ensoniq * ensoniq, unsigned int rate)
n--;
truncm = (21 * n - 1) | 1;
freq = ((48000UL << 15) / rate) * n;
- result = (48000UL << 15) / (freq / n);
if (rate >= 24000) {
if (truncm > 239)
truncm = 239;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: ens137x: remove redundant variable result
2017-10-15 21:16 [PATCH] ALSA: ens137x: remove redundant variable result Colin King
@ 2017-10-16 11:37 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-16 11:37 UTC (permalink / raw)
To: Colin King; +Cc: alsa-devel, kernel-janitors, linux-kernel, Bhumika Goyal
On Sun, 15 Oct 2017 23:16:45 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable result is being assigned a value from a calculation
> however the variable is never read, so this redundant variable
> can be removed.
>
> Cleans up clang warning: Value stored to 'result' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 21:16 [PATCH] ALSA: ens137x: remove redundant variable result Colin King
2017-10-16 11:37 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).