Re: [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths

[Vinod Koul <vinod.koul@intel.com>]

On Fri, Oct 13, 2017 at 06:13:03PM +0100, Mark Brown wrote:
> On Fri, Oct 13, 2017 at 04:50:01PM +0200, Lucas Stach wrote:
> > Am Freitag, den 13.10.2017, 15:39 +0100 schrieb Mark Brown:
> 
> > > ...I'm talking about the constraints supported on the DMA side.  I would
> > > not expect the DMA side to be accepting things it said it didn't support.
> 
> > AFAIR the caps for the supported slave bus width were introduced later
> > than other caps and not all drivers did implement them properly, so
> > validation at the core level at this time would probably have broken a
> > lot of existing users.
> 
> > That said the dmaengine core warns since kernel 4.0 if a driver doesn't
> > set those caps, so it's probably fine if we cook up a patch to do the
> > validation now.
> 
> That can should be able to be handled cleanly by enforcing any caps that
> are advertised but if the driver doesn't declare anything at all then
> just accepting anything and leaving it up to the driver to cope.

well DMAengine core cannot guess what hardware supports, but if not provided
we may want to go back to a saner default values which people might support.

But then, not doing this helps people find issues and fix them :)

So which is a better deal?

-- 
~Vinod