From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 02/14] soundwire: Add SoundWire bus type Date: Fri, 20 Oct 2017 21:50:42 +0530 Message-ID: <20171020162042.GW30097@localhost> References: <1508382211-3154-1-git-send-email-vinod.koul@intel.com> <1508382211-3154-3-git-send-email-vinod.koul@intel.com> <20171020104528.GC3210@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by alsa0.perex.cz (Postfix) with ESMTP id D92BE267708 for ; Fri, 20 Oct 2017 18:16:27 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Philippe Ombredanne Cc: ALSA , Charles Keepax , Sudheer Papothi , Takashi , Greg Kroah-Hartman , plai@codeaurora.org, LKML , Pierre , patches.audio@intel.com, Mark , srinivas.kandagatla@linaro.org, Shreyas NC , Sanyog Kale , Sagar Dharia , alan@linux.intel.com List-Id: alsa-devel@alsa-project.org On Fri, Oct 20, 2017 at 06:03:24PM +0200, Philippe Ombredanne wrote: > On Fri, Oct 20, 2017 at 12:45 PM, Greg Kroah-Hartman > wrote: > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > >> diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > >> new file mode 100644 > >> index 000000000000..a14d1de80afa > >> --- /dev/null > >> +++ b/drivers/soundwire/bus_type.c > >> @@ -0,0 +1,229 @@ > >> +/* > >> + * This file is provided under a dual BSD/GPLv2 license. When using or > >> + * redistributing this file, you may do so under either license. > >> + * > >> + * GPL LICENSE SUMMARY > >> + * > >> + * Copyright(c) 2015-17 Intel Corporation. > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of version 2 of the GNU General Public License as > >> + * published by the Free Software Foundation. > >> + * > >> + * This program is distributed in the hope that it will be useful, but > >> + * WITHOUT ANY WARRANTY; without even the implied warranty of > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> + * General Public License for more details. > >> + * > >> + * BSD LICENSE > >> + * > >> + * Copyright(c) 2015-17 Intel Corporation. > >> + * > >> + * Redistribution and use in source and binary forms, with or without > >> + * modification, are permitted provided that the following conditions > >> + * are met: > >> + * > >> + * * Redistributions of source code must retain the above copyright > >> + * notice, this list of conditions and the following disclaimer. > >> + * * Redistributions in binary form must reproduce the above copyright > >> + * notice, this list of conditions and the following disclaimer in > >> + * the documentation and/or other materials provided with the > >> + * distribution. > >> + * * Neither the name of Intel Corporation nor the names of its > >> + * contributors may be used to endorse or promote products derived > >> + * from this software without specific prior written permission. > >> + * > >> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > >> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > >> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > >> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > >> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > >> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > >> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > >> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > >> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > >> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > >> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > > > Are you _sure_ that code that interacts with the driver core can have a > > dual-license here? Have you explained to lawyers what you are doing > > here (wrapping gpl-only symbols with non-gpl-only exports)? > > > > And why dual license something that will only ever work on Linux? > > > > And finally, put a real SPDX header up there so that people don't have > > to parse that horrid amount of text to try to determine exactly what > > that license is. > > Vinod: > > It is hard to parse for people ... but it is quite hard for tools to catch > this too. This license notice is so peculiar and special that I had to > make a special detection rule just for it [1] in my tool :| > Please have mercy: could you not pick something simpler? Sorry for the trouble it caused. The code is Dual license as indicated by first two lines. I didn't invent the text here, legal folks did and used the standard template available in my company I quick grep on Dual license users looks like we already have this in kernel code. See drivers/ntb/hw/intel/ntb_hw_intel.c > [1] https://github.com/nexB/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_or_bsd-new33.RULE -- ~Vinod