From: Vinod Koul <vinod.koul@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, arnd@arndb.de, tiwai@suse.de,
linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com,
broonie@kernel.org, andriy.shevchenko@linux.intel.com,
torvalds@linux-foundation.org
Subject: Re: [RFC PATCH v2 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell
Date: Wed, 29 Nov 2017 16:01:41 +0530 [thread overview]
Message-ID: <20171129103140.GB32417@localhost> (raw)
In-Reply-To: <20171129014551.30552-6-pierre-louis.bossart@linux.intel.com>
On Tue, Nov 28, 2017 at 07:45:49PM -0600, Pierre-Louis Bossart wrote:
> Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected.
> The latter might actually need to be moved to the SOC side of things,
> it really has no place in a machine driver dependency
not really, given that we will come with platforms where I2C may not be used
for audio, we should keep this in machine or better move to codecs as it
belongs to them, machine being second best :)
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/intel/boards/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index df41a6016217..a1e169c86526 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -42,7 +42,7 @@ config SND_SOC_INTEL_HASWELL_MACH
>
> config SND_SOC_INTEL_BDW_RT5677_MACH
> tristate "ASoC Audio driver for Intel Broadwell with RT5677 codec"
> - depends on X86_INTEL_LPSS && GPIOLIB && I2C
> + depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM && GPIOLIB
> select SND_SOC_RT5677
> help
> This adds support for Intel Broadwell platform based boards with
> --
> 2.14.1
>
--
~Vinod
next prev parent reply other threads:[~2017-11-29 10:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 1:45 [RFC PATCH v2 0/7] Fix Intel audio Kconfig issues Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 1/7] ASoC: Intel: Fix Kconfig with top-level selector Pierre-Louis Bossart
2017-11-29 10:27 ` Vinod Koul
2017-11-29 10:59 ` Mark Brown
2017-11-29 14:52 ` Pierre-Louis Bossart
2017-11-30 12:24 ` Vinod Koul
2017-11-30 14:41 ` [alsa-devel] " Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 2/7] ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 3/7] ASoC: Intel: document what Kconfig options do Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 4/7] ASoC: Intel: Fix nested/unnecessary Kconfig dependencies Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 5/7] ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell Pierre-Louis Bossart
2017-11-29 10:31 ` Vinod Koul [this message]
2017-11-29 1:45 ` [RFC PATCH v2 6/7] ASoC: Intel: boards: align Kconfig configurations for HiFi2 Pierre-Louis Bossart
2017-11-29 1:45 ` [RFC PATCH v2 7/7] ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129103140.GB32417@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).