From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] ASoC: Add platforms directory
Date: Wed, 6 Dec 2017 12:39:08 +0000 [thread overview]
Message-ID: <20171206123908.GB1827@finisterre> (raw)
In-Reply-To: <20171205181448.18513-2-afd@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1079 bytes --]
On Tue, Dec 05, 2017 at 12:14:46PM -0600, Andrew F. Davis wrote:
> Platform ASoC drivers are a lot like ASoC CODEC drivers in that they
> both are independent pieces of a sound device, or "machine". Platform
> drivers should be free of CODEC specifics and visa-versa. Both are then
> used by the the "machine" driver to form the complete sound device.
> This forms a hierarchy that makes it natural to group platform drivers
> into their own directory, much like we group CODEC drivers already.
This seems like a step backwards, and your current patch set only does
this for the TI drivers anyway. Currently we have things split up by IP
holder, with machine drivers that have some platform specifics grouped
together with the matching IP drivers that may also share some platform
specific considerations. This would group all the IP drivers together
and separate them from the machine drivers they work in concert with for
no obvious benefit.
If you want to make a common directory for TI stuff do that, there's no
need to mess up all the other platforms to do that though.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-12-06 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 18:14 [RFC PATCH 0/3] Add ASoC platforms directory Andrew F. Davis
2017-12-05 18:14 ` [RFC PATCH 1/3] ASoC: Add " Andrew F. Davis
2017-12-06 12:39 ` Mark Brown [this message]
2017-12-06 16:06 ` Andrew F. Davis
2017-12-06 17:29 ` Mark Brown
2017-12-06 18:13 ` Andrew F. Davis
2017-12-06 18:42 ` Mark Brown
2017-12-06 18:49 ` Andrew F. Davis
2017-12-06 19:27 ` Mark Brown
2017-12-06 20:59 ` Andrew F. Davis
2017-12-05 18:14 ` [RFC PATCH 2/3] ASoC: Platforms: Move Davinci platform drivers into " Andrew F. Davis
2017-12-05 18:14 ` [RFC PATCH 3/3] ASoC: Platforms: Move OMAP " Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206123908.GB1827@finisterre \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox