From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: Question about soc-utils
Date: Wed, 6 Dec 2017 12:47:42 +0000 [thread overview]
Message-ID: <20171206124742.GE1827@finisterre> (raw)
In-Reply-To: <87609kzb7u.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 636 bytes --]
On Wed, Dec 06, 2017 at 05:26:54AM +0000, Kuninori Morimoto wrote:
> > > That's just an oversight, it should be using the sample size.
> The original commit was below.
> It seems original code was also assuming format width.
> Was this also oversight ?
> format_width -> physical_width changes meaning, I think...
> - switch (params_format(params)) {
> - case SNDRV_PCM_FORMAT_S16_LE:
> - case SNDRV_PCM_FORMAT_S16_BE:
> - sample_size = 16;
> - break;
> - case SNDRV_PCM_FORMAT_S20_3LE:
> - case SNDRV_PCM_FORMAT_S20_3BE:
> - sample_size = 20;
> - break;
Ah, sorry - I misread what you were saying. The above is the intention.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2017-12-06 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 8:01 Question about soc-utils Kuninori Morimoto
2017-12-05 12:39 ` Mark Brown
2017-12-06 0:06 ` Kuninori Morimoto
2017-12-06 5:26 ` Kuninori Morimoto
2017-12-06 12:47 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206124742.GE1827@finisterre \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox