From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [RFC 01/10] ASoC: Intel: Boards: Machine driver for Intel platforms Date: Wed, 6 Dec 2017 21:47:55 +0530 Message-ID: <20171206161755.GD32417@localhost> References: <1512119648-2700-1-git-send-email-rakesh.a.ughreja@intel.com> <1512119648-2700-2-git-send-email-rakesh.a.ughreja@intel.com> <67a5002e-9671-f6cd-f37b-e8c1b6d630ce@linux.intel.com> <85DFEED57DC57344B2483EF7BF8CB60579AC5C24@BGSMSX104.gar.corp.intel.com> <85DFEED57DC57344B2483EF7BF8CB60579AC5D64@BGSMSX104.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by alsa0.perex.cz (Postfix) with ESMTP id 9D58A2679B0 for ; Wed, 6 Dec 2017 17:14:16 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "liam.r.girdwood@linux.intel.com" , Patches Audio , "broonie@kernel.org" , "Ughreja, Rakesh A" List-Id: alsa-devel@alsa-project.org On Mon, Dec 04, 2017 at 09:37:37AM -0600, Pierre-Louis Bossart wrote: > On 12/4/17 9:10 AM, Ughreja, Rakesh A wrote: > >>>>> sound/soc/intel/boards/Kconfig | 10 ++ > >>>>> sound/soc/intel/boards/Makefile | 2 + > >>>>> sound/soc/intel/boards/skl_hda_generic.c | 276 > >>>>+++++++++++++++++++++++++++++++ > >>>> > >>>>can we drop the Skylake reference? It's become a catch-all term to mean > >>>>both the platform, the IP and the driver. > >>> > >>>Suggest some name. I have no problem. > >> > >>HiFi3 ? > >>iDisp ? > >>HDAudio-DSP ? > > > >hda_dsp_generic.c -- For the main file > >hda_dsp_common.c -- for common functions > > > >Does it look fine ? > > works for me. Sorry not for me. hda_dsp_xxx doesnt tie it to anything. HDA and DSP are too generic terms. But yes I don't have a better alternate than skl_generic. Here this solution is tied to a very specfic IP which is present in SKL onwards platforms.. Yes SKL is become an IP as well as platform. Maybe we should have a codename for this like azx :) -- ~Vinod