alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Augustine.Chen" <augustine.chen@intel.com>
To: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org,
	jerome.anand@intel.com, pierre-louis.bossart@intel.com,
	tiwai@suse.de
Cc: "Augustine.Chen" <augustine.chen@intel.com>
Subject: [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
Date: Fri,  8 Dec 2017 17:33:23 +0800	[thread overview]
Message-ID: <20171208093323.2212-1-augustine.chen@intel.com> (raw)

The chip data of HDMI LPE audio is set to drm_i915_private which is not
consistent with the expectation by x86 APIC driver. In the case of not
enabling CONFIG_CPUMASK_OFFSTACK, this would cause kernel panic while doing
CPU hotplug. Since the dependency of IRQ chip data was removed from HDMI
LPE audio by Commit 9bd9590997b92fbd79fd028f704f6c584b4439d7 ("drm/i915:
Stop pretending to mask/unmask LPE audio interrupts"), remove the
code of setting IRQ chip data to resolve this issue.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103731
Cc: Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
Cc: Jerome Anand <jerome.anand@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Augustine.Chen <augustine.chen@intel.com>
---
 drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
index 3bf6528..56176f9 100644
--- a/drivers/gpu/drm/i915/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
@@ -176,7 +176,7 @@ static int lpe_audio_irq_init(struct drm_i915_private *dev_priv)
 				handle_simple_irq,
 				"hdmi_lpe_audio_irq_handler");
 
-	return irq_set_chip_data(irq, dev_priv);
+	return 0;
 }
 
 static bool lpe_audio_detect(struct drm_i915_private *dev_priv)
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2017-12-08  9:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08  9:33 Augustine.Chen [this message]
2017-12-08 11:44 ` [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Ville Syrjälä
2017-12-08 22:51   ` Thomas Gleixner
2017-12-11  8:33     ` Anand, Jerome
2017-12-11 13:20       ` Ville Syrjälä
2017-12-11 13:23         ` [Intel-gfx] " Takashi Iwai
2017-12-12  9:26           ` Chen, Augustine
2017-12-12  9:45             ` [Intel-gfx] " Takashi Iwai
2017-12-13  9:25               ` Chen, Augustine
2017-12-12 17:06       ` Thomas Gleixner
2017-12-13  2:15         ` [Intel-gfx] " Anand, Jerome
2017-12-13 11:35           ` Thomas Gleixner
2017-12-13 11:52             ` Takashi Iwai
2017-12-13 14:06               ` Thomas Gleixner
2018-01-29 17:09                 ` [Intel-gfx] " Ville Syrjälä
2018-02-20 18:49                   ` Ville Syrjälä
  -- strict thread matches above, loose matches on Subject: below --
2017-12-08  8:34 Chen, Augustine
2017-12-08 11:18 ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208093323.2212-1-augustine.chen@intel.com \
    --to=augustine.chen@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jerome.anand@intel.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).