From: Mark Brown <broonie@kernel.org>
To: Olivier Moysan <olivier.moysan@st.com>
Cc: benjamin.gaignard@st.com, alsa-devel@alsa-project.org,
alexandre.torgue@st.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, arnaud.pouliquen@st.com,
tiwai@suse.com, lgirdwood@gmail.com, mcoquelin.stm32@gmail.com,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver
Date: Thu, 14 Dec 2017 17:30:25 +0000 [thread overview]
Message-ID: <20171214173025.GL9788@sirena.org.uk> (raw)
In-Reply-To: <1513270438-18523-2-git-send-email-olivier.moysan@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 336 bytes --]
On Thu, Dec 14, 2017 at 05:53:57PM +0100, Olivier Moysan wrote:
> + pdata->mclk1 = devm_clk_get(wm8994->dev, "MCLK1");
> + if (IS_ERR(pdata->mclk1))
> + pdata->mclk1 = NULL;
These should special case -EPROBE_DEFER so we defer properly if we need
to (and ideally log an error in case there was a MCLK and we legit ran
into an error).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-12-14 17:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 16:53 [RFC PATCH 0/2] select master clock in wm8994 driver based on DT clocks configuration Olivier Moysan
2017-12-14 16:53 ` [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver Olivier Moysan
2017-12-14 17:30 ` Mark Brown [this message]
2017-12-15 11:51 ` Charles Keepax
2017-12-14 16:53 ` [RFC PATCH 2/2] ASoC: select sysclk clock from mlck clock provider in wm8994 driver Olivier Moysan
2017-12-14 17:36 ` Mark Brown
2017-12-15 11:46 ` Charles Keepax
2017-12-15 15:15 ` Olivier MOYSAN
2017-12-19 9:35 ` Mark Brown
2017-12-20 12:42 ` Olivier MOYSAN
2017-12-20 15:50 ` Mark Brown
2017-12-21 10:51 ` Olivier MOYSAN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171214173025.GL9788@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=kernel@stlinux.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox