From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Lars-Peter <lars@metafoo.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Shreyas NC <shreyas.nc@intel.com>
Subject: Re: About ASoC DAIs cleanup
Date: Fri, 15 Dec 2017 09:50:53 +0530 [thread overview]
Message-ID: <20171215042053.GA18649@localhost> (raw)
In-Reply-To: <20171214113718.GB9788@sirena.org.uk>
On Thu, Dec 14, 2017 at 11:37:18AM +0000, Mark Brown wrote:
> On Thu, Dec 14, 2017 at 10:36:48AM +0530, Vinod Koul wrote:
> > On Thu, Dec 14, 2017 at 03:07:30AM +0000, Kuninori Morimoto wrote:
>
> > > > Cleaning things up so we don't need to use rtd->cpu_dai and rtd->codec_dai
> > > > would definitely be nice, it's also useful for CODEC<->CODEC links. Off
> > > > the top of my head wrapping the accesses with macros/functions then
> > > > implementing a way of getting the DAI behind them would be tractable?
>
> > Yes but one of the problems I see that we have specific ordering on the
> > DAI ops between various components, is that a specific requirement?
>
> It's designed to minimize pops, it's not a hard requirement but changing
> it might break things for existing systems.
Yes that was my hunch too, so lets keep the order unchanged.
> > > 3rd step: think about No-Categorized DAI (if possible)
> > > Because many drivers are directly using rtd->cpu_dai, rtd->codec_dai
>
> > We should fix that part while at it. I guess drivers needs own dai,
> > possibly for name or some data, so if they have helpers for that, we
> > should be able to remove those..
>
> The drivers need some way to get their driver data back and to know
> which DAI to address on multi device hardware. Most of the callbacks
> get the DAI passed in directly, that's the simplest thing.
Precisely :)
--
~Vinod
next prev parent reply other threads:[~2017-12-15 4:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171208084103.GC18649@localhost>
[not found] ` <87fu8lio74.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <20171208105545.GE18649@localhost>
[not found] ` <87shciup8e.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <87r2s2uo55.wl%kuninori.morimoto.gx@renesas.com>
[not found] ` <87o9n6ukyg.wl%kuninori.morimoto.gx@renesas.com>
2017-12-13 7:19 ` About ASoC DAIs cleanup Kuninori Morimoto
2017-12-13 15:59 ` Mark Brown
2017-12-14 3:07 ` Kuninori Morimoto
2017-12-14 5:06 ` Vinod Koul
2017-12-14 5:24 ` Kuninori Morimoto
2017-12-14 11:37 ` Mark Brown
2017-12-15 4:20 ` Vinod Koul [this message]
2017-12-18 2:16 ` Kuninori Morimoto
2017-12-19 11:23 ` Mark Brown
2017-12-21 1:28 ` Kuninori Morimoto
2017-12-21 11:25 ` Mark Brown
2017-12-22 1:23 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215042053.GA18649@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=shreyas.nc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox