From: Greg KH <gregkh@linuxfoundation.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Colin King <colin.king@canonical.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] soundwire: intel: fix missing assignment to ret
Date: Fri, 22 Dec 2017 08:15:22 +0100 [thread overview]
Message-ID: <20171222071522.GA11094@kroah.com> (raw)
In-Reply-To: <20171222033148.GN18649@localhost>
On Fri, Dec 22, 2017 at 09:01:49AM +0530, Vinod Koul wrote:
> On Thu, Dec 21, 2017 at 11:32:10PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the return status ret is being checked but it has not been
> > updated since the previous check on ret. It appears that assignment of
> > ret from return status of the call to sdw_cdns_enable_interrupt was
> > accidentally ommited. Fix this.
>
> Thanks Colin, this looks good to me.
>
> Greg, we have this and another patch from Colin, both lgtm.
>
> Would you like me to collect these and send to you before merge cycle or
> apply directly?
Please collect and then send on, as it is not in my queue at all.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-22 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 23:32 [PATCH][next] soundwire: intel: fix missing assignment to ret Colin King
2017-12-22 3:31 ` Vinod Koul
2017-12-22 7:15 ` Greg KH [this message]
2017-12-22 8:10 ` Vinod Koul
2017-12-22 12:42 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222071522.GA11094@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox