From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.
Date: Wed, 3 Jan 2018 10:50:53 +0000 [thread overview]
Message-ID: <20180103105053.GA5603@sirena.org.uk> (raw)
In-Reply-To: <20180102185314.17189-2-hdegoede@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]
On Tue, Jan 02, 2018 at 07:53:09PM +0100, Hans de Goede wrote:
> Register "micbias1" and "micbias2" to supply widegts as modern drivers do.
> - SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2,
> - RT5645_PWR_MB1_BIT, 0),
> - SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2,
> - RT5645_PWR_MB2_BIT, 0),
> + SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2,
> + RT5645_PWR_MB1_BIT, 0, NULL, 0),
> + SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2,
> + RT5645_PWR_MB2_BIT, 0, NULL, 0),
This is a good change to make but we have machines with the rt5645, are
we sure none of them use microphones? The two widget types work
differently so it needs some checking and possibly machine driver
updates to convert.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-01-03 10:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 18:53 [PATCH 0/6] ASoC: rt5645: Analog microphone fixes Hans de Goede
2018-01-02 18:53 ` [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply Hans de Goede
2018-01-03 10:50 ` Mark Brown [this message]
2018-01-03 11:01 ` Hans de Goede
2018-01-03 11:28 ` Mark Brown
2018-01-03 11:32 ` Hans de Goede
2018-01-03 11:36 ` Mark Brown
2018-01-03 12:45 ` Bard Liao
[not found] ` <ABFD875FF5FB574BA706497D987D48D702756F3C@RTITMBSV02.realtek.com.tw>
2018-01-04 10:53 ` Mark Brown
[not found] ` <ABFD875FF5FB574BA706497D987D48D7027574B8@RTITMBSV02.realtek.com.tw>
2018-01-04 12:01 ` Mark Brown
[not found] ` <ABFD875FF5FB574BA706497D987D48D702757599@RTITMBSV02.realtek.com.tw>
2018-01-04 12:41 ` Mark Brown
2018-01-02 18:53 ` [PATCH 2/6] ASoC: rt5645: add micbias power control select Hans de Goede
2018-01-04 12:37 ` Applied "ASoC: rt5645: add micbias power control select." to the asoc tree Mark Brown
2018-01-02 18:53 ` [PATCH 3/6] ASoC: rt5645: set in2_diff flag for GPD win and pocket devices Hans de Goede
2018-01-03 12:13 ` Applied "ASoC: rt5645: set in2_diff flag for GPD win and pocket devices" to the asoc tree Mark Brown
2018-01-02 18:53 ` [PATCH 4/6] ASoC: rt5645: cleanup DMI matching code Hans de Goede
2018-01-03 12:12 ` Applied "ASoC: rt5645: cleanup DMI matching code" to the asoc tree Mark Brown
2018-01-02 18:53 ` [PATCH 5/6] ASoC: rt5645: add platform data for the Teclast X80 Pro tablet Hans de Goede
2018-01-03 12:12 ` Applied "ASoC: rt5645: add platform data for the Teclast X80 Pro tablet" to the asoc tree Mark Brown
2018-01-02 18:53 ` [PATCH 6/6] ASoC: Intel: cht_bsw_rt5645: Analog Mic support Hans de Goede
2018-01-03 12:12 ` Applied "ASoC: Intel: cht_bsw_rt5645: Analog Mic support" to the asoc tree Mark Brown
2018-01-02 18:56 ` [PATCH 0/6] ASoC: rt5645: Analog microphone fixes Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103105053.GA5603@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=hdegoede@redhat.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox