[asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2777 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/wm9705
head:   93ada23cd28b04d50ddd7b3e68a93706dc28b59c
commit: 93ada23cd28b04d50ddd7b3e68a93706dc28b59c [1/1] ASoC: wm9705: replace codec to component
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 93ada23cd28b04d50ddd7b3e68a93706dc28b59c
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   sound/soc/codecs/wm9705.c: In function 'wm9705_soc_probe':
>> sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration]
      wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
                     snd_soc_new_ac97_codec
>> sound/soc/codecs/wm9705.c:330:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
                   ^
>> sound/soc/codecs/wm9705.c:339:4: error: implicit declaration of function 'snd_soc_free_ac97_component'; did you mean 'snd_soc_free_ac97_codec'? [-Werror=implicit-function-declaration]
       snd_soc_free_ac97_component(wm9705->ac97);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
       snd_soc_free_ac97_codec
   cc1: some warnings being treated as errors

vim +330 sound/soc/codecs/wm9705.c

   319	
   320	static int wm9705_soc_probe(struct snd_soc_component *component)
   321	{
   322		struct wm9705_priv *wm9705 = snd_soc_component_get_drvdata(component);
   323		struct regmap *regmap;
   324	
   325		if (wm9705->mfd_pdata) {
   326			wm9705->ac97 = wm9705->mfd_pdata->ac97;
   327			regmap = wm9705->mfd_pdata->regmap;
   328		} else {
   329	#ifdef CONFIG_SND_SOC_AC97_BUS
 > 330			wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
   331							      WM9705_VENDOR_ID_MASK);
   332			if (IS_ERR(wm9705->ac97)) {
   333				dev_err(component->dev, "Failed to register AC97 codec\n");
   334				return PTR_ERR(wm9705->ac97);
   335			}
   336	
   337			regmap = regmap_init_ac97(wm9705->ac97, &wm9705_regmap_config);
   338			if (IS_ERR(regmap)) {
 > 339				snd_soc_free_ac97_component(wm9705->ac97);
   340				return PTR_ERR(regmap);
   341			}
   342	#endif
   343		}
   344	
   345		snd_soc_component_set_drvdata(component, wm9705->ac97);
   346		snd_soc_component_init_regmap(component, regmap);
   347	
   348		return 0;
   349	}
   350	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63077 bytes --]

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]

On Mon, Feb 12, 2018 at 10:19:57PM +0800, kbuild test robot wrote:

>    sound/soc/codecs/wm9705.c: In function 'wm9705_soc_probe':
> >> sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration]
>       wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>                      snd_soc_new_ac97_codec

I've dropped this and the other patch that had the same issue.  I wonder
why 0day didn't notice this on the list...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[Kuninori Morimoto]

Hi Mark

> >    sound/soc/codecs/wm9705.c: In function 'wm9705_soc_probe':
> > >> sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration]
> >       wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
> >                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >                      snd_soc_new_ac97_codec
> 
> I've dropped this and the other patch that had the same issue.  I wonder
> why 0day didn't notice this on the list...

Oops, I didn't mention (?) but ac97 related code were
modified, and its related driver needs to be based on it.
Now, mark/topic/ac97 branch has it

----------------------------------------------------
commit c95869e5c04fb0000370e7310dc892b417b8128a
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date:   Mon Jan 29 02:58:25 2018 +0000

    ASoC: ac97: replace codec to component
    
    Now we can replace Codec to Component. Let's do it.
    
    Note:
        xxx_codec_xxx()         ->      xxx_component_xxx()
        .idle_bias_off = 0      ->      .idle_bias_on = 1
        .ignore_pmdown_time = 0 ->      .use_pmdown_time = 1
        -                       ->      .endianness = 1
        -                       ->      .non_legacy_dai_naming = 1
    
    To keep compatibilty, this patch adds snd_soc_xxx_ac97_codec()
    macro. These will be removed when all codec code was removed.
    
    Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
----------------------------------------------------

Re: [asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[Fengguang Wu]

Hi Mark,

On Mon, Feb 12, 2018 at 02:49:11PM +0000, Mark Brown wrote:
>On Mon, Feb 12, 2018 at 10:19:57PM +0800, kbuild test robot wrote:
>
>>    sound/soc/codecs/wm9705.c: In function 'wm9705_soc_probe':
>> >> sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'? [-Werror=implicit-function-declaration]
>>       wm9705->ac97 = snd_soc_new_ac97_component(component, WM9705_VENDOR_ID,
>>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>                      snd_soc_new_ac97_codec
>
>I've dropped this and the other patch that had the same issue.
>I wonder why 0day didn't notice this on the list...

Sorry but all the robot can notice is when an error disappears
in the _same_ branch that introduced the error. It does not try to
understand comments in the mailing list. Internally, it associates
errors to git branches and commits. If a problematic patch is dropped
in branch A but still remains in branch B, we should probably still
report the issue in B? 

Thanks,
Fengguang

Re: [asoc:topic/wm9705 1/1] sound/soc/codecs/wm9705.c:330:18: error: implicit declaration of function 'snd_soc_new_ac97_component'; did you mean 'snd_soc_new_ac97_codec'?

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

On Tue, Feb 13, 2018 at 12:36:20AM +0000, Kuninori Morimoto wrote:

> Oops, I didn't mention (?) but ac97 related code were
> modified, and its related driver needs to be based on it.
> Now, mark/topic/ac97 branch has it

Hrm, wonder why that didn't turn up in my grepping.  Anyway, I moved
them all onto one branch.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]