From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 1/7] ASoC: atmel: Remove redundant dev_err() call in probe function Date: Tue, 27 Feb 2018 17:54:45 +0100 Message-ID: <20180227165445.GD1479@piout.net> References: <20180130110604.GA18123@lenoch> <20180130110654.GB18123@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by alsa0.perex.cz (Postfix) with ESMTP id 7CB982676B3 for ; Tue, 27 Feb 2018 17:54:47 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180130110654.GB18123@lenoch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ladislav Michl Cc: alsa-devel@alsa-project.org, Charles Keepax , Nicolas Ferre , Kuninori Morimoto , anish kumar List-Id: alsa-devel@alsa-project.org Hi, On 30/01/2018 at 12:06:54 +0100, Ladislav Michl wrote: > There is an error message within devm_ioremap_resource already, > so remove the redundant dev_err() call. > That one can be sent as-is, don't forget to send to Mark Brown as he is the asoc maintainer. > Signed-off-by: Ladislav Michl > --- > sound/soc/atmel/atmel-classd.c | 7 ++----- > sound/soc/atmel/atmel-pdmic.c | 7 ++----- > 2 files changed, 4 insertions(+), 10 deletions(-) > > diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c > index ebabed69f0e6..540f0b6a95aa 100644 > --- a/sound/soc/atmel/atmel-classd.c > +++ b/sound/soc/atmel/atmel-classd.c > @@ -580,11 +580,8 @@ static int atmel_classd_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > io_base = devm_ioremap_resource(dev, res); > - if (IS_ERR(io_base)) { > - ret = PTR_ERR(io_base); > - dev_err(dev, "failed to remap register memory: %d\n", ret); > - return ret; > - } > + if (IS_ERR(io_base)) > + return PTR_ERR(io_base); > > dd->phy_base = res->start; > > diff --git a/sound/soc/atmel/atmel-pdmic.c b/sound/soc/atmel/atmel-pdmic.c > index 8e3d34be9e69..0729f656f7eb 100644 > --- a/sound/soc/atmel/atmel-pdmic.c > +++ b/sound/soc/atmel/atmel-pdmic.c > @@ -629,11 +629,8 @@ static int atmel_pdmic_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > io_base = devm_ioremap_resource(dev, res); > - if (IS_ERR(io_base)) { > - ret = PTR_ERR(io_base); > - dev_err(dev, "failed to remap register memory: %d\n", ret); > - return ret; > - } > + if (IS_ERR(io_base)) > + return PTR_ERR(io_base); > > dd->phy_base = res->start; > > -- > 2.15.1 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com