From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 6/7] ASoC: max9867: Fix BSEL value in master mode. Date: Tue, 27 Feb 2018 18:23:09 +0100 Message-ID: <20180227172309.GG1479@piout.net> References: <20180130110604.GA18123@lenoch> <20180130111033.GG18123@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by alsa0.perex.cz (Postfix) with ESMTP id DB9832676FB for ; Tue, 27 Feb 2018 18:23:10 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180130111033.GG18123@lenoch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ladislav Michl Cc: alsa-devel@alsa-project.org, Charles Keepax , Nicolas Ferre , Kuninori Morimoto , anish kumar List-Id: alsa-devel@alsa-project.org This also needs a proper commit message. On 30/01/2018 at 12:10:33 +0100, Ladislav Michl wrote: > Signed-off-by: Ladislav Michl > --- > Note: It should be reconsidered where BSEL should be set. > > sound/soc/codecs/max9867.c | 43 +++---------------------------------------- > 1 file changed, 3 insertions(+), 40 deletions(-) > > diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c > index 026b7cf94910..6272cf5df4a9 100644 > --- a/sound/soc/codecs/max9867.c > +++ b/sound/soc/codecs/max9867.c > @@ -148,46 +148,6 @@ static int max9867_dai_hw_params(struct snd_pcm_substream *substream, > MAX9867_RAPID_LOCK, MAX9867_RAPID_LOCK); > regmap_update_bits(max9867->regmap, MAX9867_AUDIOCLKHIGH, > MAX9867_PLL, MAX9867_PLL); > - } else { > - unsigned long int bclk_rate, pclk_bclk_ratio; > - int bclk_value; > - > - bclk_rate = params_rate(params) * 2 * params_width(params); > - pclk_bclk_ratio = max9867->pclk/bclk_rate; > - switch (params_width(params)) { > - case 8: > - case 16: > - switch (pclk_bclk_ratio) { > - case 2: > - bclk_value = MAX9867_IFC1B_PCLK_2; > - break; > - case 4: > - bclk_value = MAX9867_IFC1B_PCLK_4; > - break; > - case 8: > - bclk_value = MAX9867_IFC1B_PCLK_8; > - break; > - case 16: > - bclk_value = MAX9867_IFC1B_PCLK_16; > - break; > - default: > - dev_err(codec->dev, > - "unsupported sampling rate\n"); > - return -EINVAL; > - } > - break; > - case 24: > - bclk_value = MAX9867_IFC1B_24BIT; > - break; > - case 32: > - bclk_value = MAX9867_IFC1B_32BIT; > - break; > - default: > - dev_err(codec->dev, "unsupported sampling rate\n"); > - return -EINVAL; > - } > - regmap_update_bits(max9867->regmap, MAX9867_IFC1B, > - MAX9867_IFC1B_BCLK_MASK, bclk_value); > } > return 0; > } > @@ -244,6 +204,9 @@ static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai, > value &= ~MAX9867_FREQ_MASK; > regmap_update_bits(max9867->regmap, MAX9867_SYSCLK, > MAX9867_PSCLK_MASK, value); > + regmap_update_bits(max9867->regmap, MAX9867_IFC1B, > + MAX9867_IFC1B_BCLK_MASK, 0x010); This magic value has to be defined somewhere. > + > return 0; > } > > -- > 2.15.1 > -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com