From: Ladislav Michl <ladis@linux-mips.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH 6/6] ASoC: max9867: Use continuous sample rate
Date: Thu, 1 Mar 2018 22:47:08 +0100 [thread overview]
Message-ID: <20180301214708.GA4302@lenoch> (raw)
In-Reply-To: <20180301182202.GH12864@sirena.org.uk>
On Thu, Mar 01, 2018 at 06:22:02PM +0000, Mark Brown wrote:
> On Thu, Mar 01, 2018 at 03:22:16PM +0100, Ladislav Michl wrote:
>
> > what is exact meaning of SNDRV_PCM_RATE_CONTINUOUS? What if codec is
> > able to set "any" rate, but there are rounding errors?
> > Shall we pick exact matches based on master clock frequency?
> > Few other drivers are also setting SNDRV_PCM_RATE_CONTINUOUS, but
> > certainly cannot set any rate exactly.
>
> It means being able to set any rate exactly. Many devices have hardware
> which is only specified to work at specific rates but some are more
> flexible. Devices don't need to be able to do this independently, you
> can have a flexible external clock tree for example.
Thanks for clarifying this. So in this particular case we should use
snd_pcm_hw_constraint_list for SNDRV_PCM_HW_PARAM_RATE to enforce only
supported rates based on master clock, right? I'll rework this patch then.
ladis
next prev parent reply other threads:[~2018-03-01 21:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 14:18 [PATCH 0/6] ASoC: max9867: Driver update Ladislav Michl
2018-03-01 14:19 ` [PATCH 1/6] ASoC: max9867: Show Kconfig entry Ladislav Michl
2018-03-01 14:19 ` [PATCH 2/6] ASoC: max9867: Improve error logging Ladislav Michl
2018-03-01 18:06 ` Applied "ASoC: max9867: Improve error logging" to the asoc tree Mark Brown
2018-03-01 14:20 ` [PATCH 3/6] ASoC: max9867: Drop probe function Ladislav Michl
2018-03-01 17:56 ` Mark Brown
2018-03-01 20:06 ` Ladislav Michl
2018-03-01 20:39 ` Mark Brown
2018-03-01 21:32 ` Ladislav Michl
2018-03-01 21:37 ` Mark Brown
2018-03-02 13:17 ` Applied "ASoC: max9867: Drop probe function" to the asoc tree Mark Brown
2018-03-01 14:20 ` [PATCH 4/6] ASoC: max9867: Fix codec capabilities Ladislav Michl
2018-03-01 18:06 ` Applied "ASoC: max9867: Fix codec capabilities" to the asoc tree Mark Brown
2018-03-01 14:21 ` [PATCH 5/6] ASoC: max9867: DSP mode Ladislav Michl
2018-03-01 18:06 ` Applied "ASoC: max9867: DSP mode" to the asoc tree Mark Brown
2018-03-01 14:22 ` [PATCH 6/6] ASoC: max9867: Use continuous sample rate Ladislav Michl
2018-03-01 18:22 ` Mark Brown
2018-03-01 21:47 ` Ladislav Michl [this message]
2018-03-02 10:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301214708.GA4302@lenoch \
--to=ladis@linux-mips.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox