From: kbuild test robot <lkp@intel.com>
To: Matt Porter <mporter@konsulko.com>
Cc: kbuild-all@01.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: fix boolreturn.cocci warnings
Date: Sat, 3 Mar 2018 06:48:09 +0800 [thread overview]
Message-ID: <20180302224809.GA27408@lkp-sbx04> (raw)
In-Reply-To: <20180227225128.17815-3-mporter@konsulko.com>
From: Fengguang Wu <fengguang.wu@intel.com>
sound/soc/codecs/tda7419.c:151:9-10: WARNING: return of 0/1 in function 'tda7419_vol_is_stereo' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: d811df0fabec ("ASoC: add tda7419 audio processor driver")
CC: Matt Porter <mporter@konsulko.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
tda7419.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/soc/codecs/tda7419.c
+++ b/sound/soc/codecs/tda7419.c
@@ -148,9 +148,9 @@ struct tda7419_vol_control {
static inline bool tda7419_vol_is_stereo(struct tda7419_vol_control *tvc)
{
if (tvc->reg == tvc->rreg)
- return 0;
+ return false;
- return 1;
+ return true;
}
static int tda7419_vol_info(struct snd_kcontrol *kcontrol,
next prev parent reply other threads:[~2018-03-02 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 22:51 [PATCH 0/2] TDA7419 audio processor driver Matt Porter
2018-02-27 22:51 ` [PATCH 1/2] ASoC: add tda7419 audio processor binding Matt Porter
2018-03-05 22:29 ` Rob Herring
2018-03-09 14:39 ` Matt Porter
2018-02-27 22:51 ` [PATCH 2/2] ASoC: add tda7419 audio processor driver Matt Porter
2018-02-28 11:00 ` Mark Brown
2018-03-09 14:35 ` Matt Porter
2018-03-09 15:29 ` Mark Brown
2018-03-18 17:21 ` Matt Porter
2018-03-02 22:48 ` kbuild test robot [this message]
2018-03-02 22:48 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302224809.GA27408@lkp-sbx04 \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mporter@konsulko.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).